-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): do not fill empty records #467
Conversation
5923e9c
to
d8f7e99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 59.92% 59.93%
=======================================
Files 71 71
Lines 4462 4463 +1
=======================================
+ Hits 2674 2675 +1
Misses 1169 1169
Partials 619 619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
follow up of: #466, prevent unset records to be filled with empty tables: {}
d8f7e99
to
ceae801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
I believe this should get a changelog entry, right?
oops, looks like some entries are missing there for the past couple of releases, I think we should open a separate PR to fill those in at once, before releasing, let me know if that sounds good to you @pmalek |
Sounds good! Be sure to include the changelog links in the created releases as stated in Lines 5 to 7 in 76af65d
|
follow up of: #466, prevent unset records to be filled with empty tables: {}
KAG-5380