Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): allow choosing what fields to fill #466

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

samugi
Copy link
Member

@samugi samugi commented Sep 3, 2024

enhance the utils: FillPluginsDefaults* functions to allow individually selecting whether to fill normal and auto fields with default values

KAG-5317

enhance the utils: FillPluginsDefaults* functions to allow individually
selecting whether to fill normal and auto fields with default values.
@samugi samugi requested review from a team as code owners September 3, 2024 13:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.92%. Comparing base (45107a3) to head (ba013c0).

Files with missing lines Patch % Lines
kong/utils.go 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   59.87%   59.92%   +0.05%     
==========================================
  Files          71       71              
  Lines        4461     4462       +1     
==========================================
+ Hits         2671     2674       +3     
+ Misses       1170     1169       -1     
+ Partials      620      619       -1     
Flag Coverage Δ
2.1 36.41% <82.35%> (+0.05%) ⬆️
2.2 48.78% <82.35%> (+0.05%) ⬆️
2.3 49.41% <82.35%> (+0.05%) ⬆️
2.4 49.46% <82.35%> (+0.05%) ⬆️
2.5 49.46% <82.35%> (+0.05%) ⬆️
2.6 49.46% <82.35%> (+0.05%) ⬆️
2.7 51.14% <82.35%> (+0.05%) ⬆️
2.8 51.14% <82.35%> (+0.05%) ⬆️
3.0 55.26% <82.35%> (+0.05%) ⬆️
3.1 56.88% <82.35%> (+0.05%) ⬆️
3.2 56.88% <82.35%> (+0.05%) ⬆️
3.3 56.88% <82.35%> (+0.05%) ⬆️
3.4 59.23% <82.35%> (+0.05%) ⬆️
3.5 57.05% <82.35%> (+0.05%) ⬆️
3.6 57.05% <82.35%> (+0.05%) ⬆️
community 44.17% <82.35%> (+0.05%) ⬆️
enterprise 58.35% <82.35%> (+0.05%) ⬆️
integration 59.92% <82.35%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samugi samugi marked this pull request as draft September 3, 2024 14:46
@samugi samugi marked this pull request as ready for review September 3, 2024 15:37
@samugi samugi merged commit 76af65d into main Sep 4, 2024
79 checks passed
@samugi samugi deleted the feat/utils-auto-fill branch September 4, 2024 07:39
samugi added a commit that referenced this pull request Sep 11, 2024
follow up of: #466, prevent unset
records to be filled with empty tables: {}
samugi added a commit that referenced this pull request Sep 11, 2024
follow up of: #466, prevent unset
records to be filled with empty tables: {}
samugi added a commit that referenced this pull request Sep 11, 2024
follow up of: #466, prevent unset
records to be filled with empty tables: {}
Prashansa-K pushed a commit that referenced this pull request Sep 12, 2024
follow up of: #466, prevent unset
records to be filled with empty tables: {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants