Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix P2P messages backwards compatibilty in update_maker_order PR #960

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

shamardy
Copy link
Collaborator

fixes #958

@artemii235
Copy link
Member

@shamardy Please fix the WASM build, the Test MM2 WASM stage failed on the CI.

Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There is just one comment 🙂

mm2src/lp_ordermatch.rs Outdated Show resolved Hide resolved
@shamardy
Copy link
Collaborator Author

Just to clarify this code

conf_settings: if let Some(settings) = new_order.new_conf_settings() {
    if Some(settings) == old_order.conf_settings {
        None
    } else {
        old_order.conf_settings
    }
} else {
    None
},

the first if condition is used to check if V1 is used. the second is to check if update_maker_order was called with the same conf_settings as before so the conf_settings are not written in history as changed.

Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing I can add :)

@artemii235 artemii235 merged commit bd6bed0 into dev Jun 1, 2021
@artemii235 artemii235 deleted the mm2.1-hot-fix-makerorderupdated-msg branch June 1, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants