Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P messages backwards compatibilty broken in update_maker_order PR. #958

Closed
artemii235 opened this issue May 31, 2021 · 3 comments
Closed
Assignees

Comments

@artemii235
Copy link
Member

I've not noticed it on the review, the conf_settings field added in the middle of the MakerOrderUpdated struct (https://github.com/KomodoPlatform/atomicDEX-API/pull/926/files#diff-0ae60f6965c551b5346cbb5602722fc4f59850c124ceb8ad489a6aee83b9d5a5R146) breaks the compatibility: old node can't deserialize message from the new one and vice versa. The error is 29 08:14:52, lp_ordermatch:392] ERROR Error invalid type: integer 1622276092, expected struct OrderConfirmationsSettings while decoding signed message.

@shamardy Please hotfix this and add the compatibility unit test similar to https://github.com/KomodoPlatform/atomicDEX-API/pull/945/files#diff-f8d46f22e9ae968ffa2d54a792961082eefb229a4c4fe38bc49793120c806324R1456

@artemii235 artemii235 added the P0 label May 31, 2021
artemii235 pushed a commit that referenced this issue Jun 1, 2021
…#960)

* P2P msg backward compatibilty in MakerOrderUpdated

* fix WASM test build

* remove V1 error in HistoricalOrder build function
@artemii235
Copy link
Member Author

@cipig Could you please test that MM2 nodes built from the mm2.1 branch and the dev branch are compatible with each other? They should order match and swap successfully, partially matched maker orders should be properly updated on the network.

@cipig
Copy link
Member

cipig commented Jun 1, 2021

RICK/MORTY swaps between mm2.1 and dev branch work fine, above error (invalid type) is gone and maker order is updated (volume reduced) after partial match.

@artemii235
Copy link
Member Author

Thanks for the prompt fix and test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants