You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@cipig Could you please test that MM2 nodes built from the mm2.1 branch and the dev branch are compatible with each other? They should order match and swap successfully, partially matched maker orders should be properly updated on the network.
RICK/MORTY swaps between mm2.1 and dev branch work fine, above error (invalid type) is gone and maker order is updated (volume reduced) after partial match.
I've not noticed it on the review, the
conf_settings
field added in the middle of theMakerOrderUpdated
struct (https://github.com/KomodoPlatform/atomicDEX-API/pull/926/files#diff-0ae60f6965c551b5346cbb5602722fc4f59850c124ceb8ad489a6aee83b9d5a5R146) breaks the compatibility: old node can't deserialize message from the new one and vice versa. The error is29 08:14:52, lp_ordermatch:392] ERROR Error invalid type: integer 1622276092, expected struct OrderConfirmationsSettings while decoding signed message
.@shamardy Please hotfix this and add the compatibility unit test similar to https://github.com/KomodoPlatform/atomicDEX-API/pull/945/files#diff-f8d46f22e9ae968ffa2d54a792961082eefb229a4c4fe38bc49793120c806324R1456
The text was updated successfully, but these errors were encountered: