Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add essential features to BTH-RM #6996

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Add essential features to BTH-RM #6996

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93e1262
Add essential features to BTH-RM
danielpetrovic Feb 1, 2024
c863815
Update src/devices/bosch.ts
danielpetrovic Feb 1, 2024
a247467
Merge branch 'master' into patch-1
danielpetrovic Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/devices/bosch.ts
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this update the BTH-RA (RBSH-TRV0-ZB-EU) work firmware 3.05.09, the window open switch is broken for me. Not sure how to support you to sort it out. Let me know

Copy link
Contributor Author

@danielpetrovic danielpetrovic Feb 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this patch was not the cause. The problem was caused by changing another file by someone else.

The issue is fixed (#7047) in Z2M 1.36 and if you run Edge version.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback, good do know! Than I'll wait for 1.36 being released for the homeassistant addon before I update.

Original file line number Diff line number Diff line change
Expand Up @@ -1160,13 +1160,15 @@
description: 'Room thermostat II (Battery model)',
fromZigbee: [fz.humidity, fz.thermostat, fz.battery, fzLocal.bosch_thermostat, fzLocal.bosch_userInterface],
toZigbee: [tz.thermostat_occupied_heating_setpoint, tz.thermostat_local_temperature_calibration,
tz.thermostat_local_temperature, tz.thermostat_keypad_lockout, tzLocal.bosch_thermostat, tzLocal.bosch_userInterface],
tz.thermostat_local_temperature, tz.thermostat_keypad_lockout, tz.thermostat_running_state,
tzLocal.bosch_thermostat, tzLocal.bosch_userInterface],
exposes: [
e.climate()
.withLocalTemperature()
.withSetpoint('occupied_heating_setpoint', 5, 30, 0.5)
.withLocalTemperatureCalibration(-12, 12, 0.5)
.withSystemMode(['off', 'heat', 'auto']),
danielpetrovic marked this conversation as resolved.
Show resolved Hide resolved
.withRunningState(['idle', 'heat'], ea.STATE_GET),

Check failure on line 1171 in src/devices/bosch.ts

View workflow job for this annotation

GitHub Actions / ci 

Expression expected.
e.humidity(),
e.binary('window_open', ea.ALL, 'ON', 'OFF').withDescription('Window open'),
e.child_lock().setAccess('state', ea.ALL),
Expand All @@ -1182,6 +1184,20 @@
await reporting.thermostatTemperature(endpoint);
await reporting.humidity(endpoint);

// report operating_mode (system_mode)
await endpoint.configureReporting('hvacThermostat', [{
attribute: {ID: 0x4007, type: Zcl.DataType.enum8},
minimumReportInterval: 0,
maximumReportInterval: constants.repInterval.HOUR,
reportableChange: 1,
}], manufacturerOptions);
// report pi_heating_demand (valve opening)
await endpoint.configureReporting('hvacThermostat', [{
attribute: {ID: 0x4020, type: Zcl.DataType.enum8},
minimumReportInterval: 0,
maximumReportInterval: constants.repInterval.HOUR,
reportableChange: 1,
}], manufacturerOptions);
// report is window_open
await endpoint.configureReporting('hvacThermostat', [{
attribute: {ID: 0x4042, type: Zcl.DataType.enum8},
Expand All @@ -1191,7 +1207,7 @@
}], manufacturerOptions);

await endpoint.read('hvacThermostat', ['localTemperatureCalibration']);
await endpoint.read('hvacThermostat', [0x4007, 0x4042, 0x4043], manufacturerOptions);
await endpoint.read('hvacThermostat', [0x4007, 0x4020, 0x4042], manufacturerOptions);
await endpoint.read('hvacUserInterfaceCfg', ['keypadLockout']);
await endpoint.read('hvacUserInterfaceCfg', [0x403a, 0x403b], manufacturerOptions);
},
Expand Down
Loading