Change window_open to window_detection for Bosch Thermostats.

[danielpetrovic]

Discussed here: Koenkk/zigbee2mqtt#21285

[danielpetrovic]

I am testing this, but now I get:

No converter available for 'window_open' ("ON")
No converter available for 'window_open' ("OFF")

And it still doesn't show up in HA. Can anyone help to change the window_open to windows_detection properly?

[GatoPharaoh]

sorry, didn't see you already opened a pull request - looks good to me, works on my end

No converter available for 'window_open' ("ON")
No converter available for 'window_open' ("OFF")

had that as well - i guess you have an automation in HA that sets sends the window state to the bosch devices every time they are triggered. restarting z2m does trigger the automation in home assistant as the state for the window sensors "changes" on startup. fix your automation in HA from window_open to window_detection and No converter available for 'window_open' ("OFF") should dissappear

And it still doesn't show up in HA

had this on the first restart - my BTH-RAs needed to reconfigure once. just press reconfigure in the frontend. triggering the window_detection switch via z2m frontend made it also appear in home assistant. maybe it's just cached on your end.

[danielpetrovic]

How can you keep the changes persistent? First time I reboot Zigbee2MQTT after I change the Bosch.js file it stays and I can test the changes. But then when I reboot again it reverts to the one in the repository…

I still had the No Converter Available error after reconfiguring so wanted to reboot to test and then it reverted to previous version…

I am using the HA Add-On.

[GatoPharaoh]

as I use HA-core, I don't really know how addons work. I just set up a test environment following Koenkks advice

[danielpetrovic]

I cannot do a setup like the example mentions but did find a better way to edit the file inside the add-on through Advanced SSH & Web Terminal Add-on.

I was able to test it now and it seems to work ok here as well with the BTH-RM. So this was all the change that was needed to fix the switch. So it can be merged.

[Koenkk]

@danielpetrovic you forgot to update

zigbee-herdsman-converters/src/devices/bosch.ts

Line 1059 in aeea2fc

e.binary('window_open', ea.ALL, 'ON', 'OFF')

[danielpetrovic]

@danielpetrovic you forgot to update

zigbee-herdsman-converters/src/devices/bosch.ts

Line 1059 in aeea2fc

e.binary('window_open', ea.ALL, 'ON', 'OFF')

It is there when I check in 9dfb5a4 is this not the latest commit?
There are 11 occurrences of window_open and I've changed 11 entities.

The one you are linking to, somehow goes to tuya.ts when I click it.

[Koenkk]

You are right, somehow missed it, thanks!

[salopette]

Koenkk/zigbee2mqtt#21208 (comment)