CMake messages changed to message( STATUS "..." ) #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in an earlier comment: When using the CMake GUI or IDEs calling CMake, using message( STATUS ... ) ensures that only warnings and errors are printed in red.
Because g3log CMake scripts are rather verbose, this would help filtering critical messages out. I understand that the warning level of g3log diagnostic messages may also be intentional to make them more visible over generic CMake output. In this case, feel free to just close without further ado or remove the "STATUS" from those messages you feel need to be highlighted at a warning level.
BTW, you mentioned the
if( "${VAR}.x" STREQUAL ".x" )syntax in an earlier comment. I believed this may just have been needed for the ${VERSION} variable as it is also a CMake keyword in some commands. However, for me evenif( NOT VERSION )in the root CMakeLists.txt does the job.