Cross-compiling: Version readout fixed #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test.cmake: Path handling consistent
AndreasSchoenle
changed the title
|
👍 looks good |
KjellKod
reviewed
May 17, 2017
| @@ -11,12 +11,6 @@ | |||
| #include <g3log/logworker.hpp> | |||
| #include "tester_sharedlib.h" | |||
|
|
|||
| #if (defined(CHANGE_G3LOG_DEBUG_TO_DBUG)) | |||
KjellKod
reviewed
May 17, 2017
| IF (${VERSION}.x STREQUAL ".x") | ||
| IF (MSVC) | ||
| IF ( NOT VERSION ) | ||
| IF ( "${CMAKE_HOST_SYSTEM_NAME}" STREQUAL "Windows" ) |
KjellKod
reviewed
May 17, 2017
| set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) | ||
| ELSE() | ||
| message( FATAL "Need CMake version >=3.4 to build shared windows library!" ) | ||
| IF( WIN32 ) |
There was a problem hiding this comment.
Why WIN32 check and not?:
IF ( "${CMAKE_HOST_SYSTEM_NAME}" STREQUAL "Windows" )
|
👍 @AndreasSchoenle it looks good. I had only one question that I was curious about. After you answer that I'll go ahead and merge it. |
|
Tested and needed for cmake-changes4 #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition to cmake-changes2: When cross compiling MSVC is of course not set on windows. Also it just checks whether using the MS compiler - will also not be set for mingw. Thus checking for the host OS and determining on which system the command is actually run on seems the way to go.