Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to ensure array push is immutable #4361

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

guptaarnav
Copy link
Collaborator

Adding test requested by @jtran in #4232 (comment)

Ensures that when an element is pushed to an array, that element is not available on the original array.

Copy link

qa-wolf bot commented Oct 30, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 30, 2024 10:20pm

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (0d52851) to head (9620c98).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4361      +/-   ##
==========================================
+ Coverage   85.86%   86.07%   +0.21%     
==========================================
  Files          77       78       +1     
  Lines       27434    27621     +187     
==========================================
+ Hits        23557    23776     +219     
+ Misses       3877     3845      -32     
Flag Coverage Δ
wasm-lib 86.07% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@guptaarnav guptaarnav enabled auto-merge (squash) October 30, 2024 22:57
@guptaarnav guptaarnav merged commit a8b816a into main Oct 30, 2024
32 checks passed
@guptaarnav guptaarnav deleted the guptaarnav/array-push-test branch October 30, 2024 23:04
@franknoirot franknoirot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants