implemented array push

[guptaarnav]

Addressing feature request from #4127, added array std lib function 'push' which takes in an array and an element, and returns a new array with the element appended to the end.

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Oct 18, 2024 11:42pm

[jtran]

This technically works, but if anyone pushes inside a loop, it's O(n^2). Do we really want to introduce this? Seems like a big foot-gun.

I will propose an alternative in the issue.

[nrc]

I haven't reviewed this but I'd be happy to merge for now on the understanding that we need to review all our array functionality and probably change both the interfaces and implementation. I think re-implementing arrays using some kind of other data structure would be a big job and we shouldn't do that until we have a proper plan

[jtran]

I don't think it would be that much work at our current stage. Assuming we fix #1130, the only things that interact with arrays are literals, map(), reduce(), and a few of the stdlib functions like extrude() that accept an iterable.

But if you @nrc think this is the way to go, that's fine with me.

[jtran]

Can you add another test that pushes to an array and tries to get the new element's index on the original array? Using gen_test_fail!(), we assert that it fails since the original array shouldn't get modified. As far as I know, we don't yet have a way to get the length of an array.

[lf94]

Succeeded by #4341