Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.26.1 #4289

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Cut release v0.26.1 #4289

merged 2 commits into from
Oct 24, 2024

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Oct 24, 2024

What's Changed

Full Changelog: v0.26.0...v0.26.1

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 24, 2024 5:20pm

Copy link

qa-wolf bot commented Oct 24, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch release makes sense

@franknoirot
Copy link
Collaborator

franknoirot commented Oct 24, 2024

MacOS smoke testing

  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
    • Coredump doesn't work until you open a project, and doesn't work if you're in sketch mode.
  • running app.{app,exe} path/to/file opens the kcl file (all oses)
    • If you pass in a nonexistent path, the app hangs in a blank state
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses)
  • If someone at the office, test you can hit make from the app and it works
  • Test updating versions works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
  • Electron tests: ensure we can open files that in tauri we would not be able to Electron tests: ensure we can open files that in tauri we would not be able to #3455
  • Electron test: upgrading app should not cause user to have to auth again Electron test: upgrading app should not cause user to have to auth again #3469
  • Electron: logging in and authing works Electron: logging in and authing works #3465
  • double click to open files from finder opens new window each time (mac/windows)
  • export from the app works and opens a file picker ux (needs to be manual since we override for playwright)
  • Ensure that a loading toast appears when testing the auto-updater, saying the download has begun
  • Token.txt should work Token.txt should work #4038

Notes

I ran into an issue with the MacOS updater build being flagged as "damaged" and not opening. @lf94's Linux test went fine.

@lf94
Copy link
Contributor Author

lf94 commented Oct 24, 2024

Linux cleared

Manual Tasks

@franknoirot
Copy link
Collaborator

franknoirot commented Oct 24, 2024

Updater test on Mac passed after reverting #4270 and updating the release branch. Ready to merge

@franknoirot franknoirot merged commit e9033e1 into main Oct 24, 2024
26 checks passed
@franknoirot franknoirot deleted the cut-release-v0.26.1 branch October 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants