Separate debug/release electron-builder to help mac job #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will attempt to fix #4199
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
This reverts commit f2c0c24.
…-on-build-apps-mac-job
franknoirot
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Was this intentionally committed?
There was a problem hiding this comment.
Thank you @franknoirot! Forgot to mention, yes, this is also fixing electron-builder locally that expects this file to exist with the config we have. We write over it in CI https://github.com/KittyCAD/modeling-app/blob/main/.github/workflows/build-test-publish-apps.yml#L61
pierremtb
deleted the
pierremtb/issue4199-Fix-sporadic-SyntaxError-on-build-apps-mac-job
branch
Merged
franknoirot
added a commit
that referenced
this pull request
Oct 24, 2024
This reverts commit 19d01c5.
lf94
pushed a commit
that referenced
this pull request
Oct 24, 2024
pierremtb
restored the
pierremtb/issue4199-Fix-sporadic-SyntaxError-on-build-apps-mac-job
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will attempt to fix #4199