Chore: separate out projectMachine from Home route #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
reviewed
Oct 7, 2024
jtran
approved these changes
Oct 7, 2024
|
Good lord this one was frustrating. But it's green. And now projects can be navigated more effectively. |
|
merge it |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereq for some of the features in #4088. We have not been able to perform any project management commands from within a project up until now, because the project management state machine was embedded within the
/homeroute. This makes it available across all routes, so users (or, importantly for #4088, other actors) can perform CRUD operations on projects while inside a project.Adds 4 E2E tests to check the rename and delete functionality both from home and in the project to be acted upon, since those are the trickier cases. It verifies that we: