-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for creating a file via link, and add ability to generate and share such links #4088
Comments
we will want the nice modals that are like yo tthe units are different than your current project if they add to existing so we will want to pass the units as well |
all the investment into nice modals and user experience here will be reused on:
so its worth really making this flow nice as it will be used A LOT |
Oh nice yeah we can just add the units as another query parameter and corresponding argument to the command! I've updated the description to include that. |
I'm planning on routing this through the command palette, like how the current implementation of the "Open a sample" command works. Is that okay? There will be warnings on the confirmation step too, I just like reusing that UX path for as much as we can, but I want to make sure you don't have a specific new idea of modals and UX here that I should implement. |
What is the plan to gracefully handle the user doing this workflow multiple times for the same URL? |
@nadr0 I think the idea is that the user gets the opportunity to create a new file each time, with the option to update to provide a new file/project name as well. I know that we have logic that gracefully increments duplicate file names so repeat use should not be a problem there, but I need to test repeat project creation to make sure it doesn't blindly overwrite existing projects. |
I am realizing that the fact that our web experience doesn't have a |
I realize that this would mean anyone who opens the link in the desktop app would never have access to adding the file to an existing project. I need a That being said, I think the user workflow is as follows, with some technical details for my memory:
|
The workflow you described looks good. Do we want to add any other default information to the I don't think we should encode the project folder structure but I think the default filename could be useful. |
Yes for sure! There's a |
method
newFile
adds a file to the root of the current project and gives the file the value ofname
newProject
adds a project withname
and adds amain.kcl
file within. Hide this on webprojectName
only required if thenewFile
argument is selectedcode
units
name
?create_file
that, whenever present, triggers this command with the code value found in acode
query parameter, and units value in aunits
one.code
will be base64 encodedFuture work
2
is implementedThe text was updated successfully, but these errors were encountered: