Skip to content
This repository has been archived by the owner on Feb 13, 2025. It is now read-only.

MLIBZ-2520: Delete items properly with Auto Pagination #298

Merged
merged 4 commits into from
May 23, 2018
Merged

MLIBZ-2520: Delete items properly with Auto Pagination #298

merged 4 commits into from
May 23, 2018

Conversation

thomasconner
Copy link
Contributor

Steps to reproduce:

  1. Create a few items in the server and pull them locally
  2. Enable auto-pagination
  3. Delete a few items in the server
  4. Pull with auto-pagination

Expected result

Items are deleted locally

Actual result

Items are not deleted locally

Changes

  • Remove all entities in the cache for a collection before loading pages using auto pagination

Tests

  • Updated the existing unit test for this scenario
  • Added an integration test for this scenario

@thomasconner thomasconner self-assigned this May 23, 2018
vinaygahlawat
vinaygahlawat approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasconner thomasconner merged commit 20d9081 into master May 23, 2018
@thomasconner thomasconner deleted the mhristov/MLIBZ-2520-Test-for-deleted-items-with-AP branch May 23, 2018 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinaygahlawat vinaygahlawat vinaygahlawat approved these changes

Assignees

@thomasconner thomasconner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasconner @vinaygahlawat