MLIBZ-2520: Delete items properly with Auto Pagination (#298)

* added test for deleted items with AP * MLIBZ-2520: Clear the collection before loading pages with auto pagination * Fix failing unit test
Kinvey · May 23, 2018 · 20d9081 · 20d9081
1 parent 824a312
commit 20d9081
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 6 deletions.
diff --git a/src/core/datastore/sync/sync-manager.js b/src/core/datastore/sync/sync-manager.js
@@ -473,7 +473,7 @@ export class SyncManager {
     return this._getExpectedEntityCount(collection, userQuery)
       .then(({ lastRequest, count }) => {
         pullQuery = this._getInternalPullQuery(userQuery, count);
-        return this._deleteOfflineEntities(collection, pullQuery)
+        return this._deleteOfflineEntities(collection)
           .then(() => {
             const pageSizeSetting = options.autoPagination && options.autoPagination.pageSize;
             const pageSize = pageSizeSetting || maxEntityLimit;

diff --git a/src/core/datastore/working-with-data-tests/sync-manager.spec.js b/src/core/datastore/working-with-data-tests/sync-manager.spec.js
@@ -378,14 +378,11 @@ describe('SyncManager delegating to repos and SyncStateManager', () => {
           });
       });
 
-      it('should call OfflineRepo.delete() with the internal pull query', () => {
+      it('should call OfflineRepo.delete() without a query', () => {
         utilsMock.splitQueryIntoPages = expect.createSpy().andReturn([]);
         return syncManager.pull(collection, null, options)
           .then(() => {
-            const internalQueryMock = new Query();
-            internalQueryMock.limit = backendEntityCount;
-            internalQueryMock.sort = { [defaultSortField]: 1 };
-            validateSpyCalls(offlineRepoMock.delete, 1, [collection, internalQueryMock]);
+            validateSpyCalls(offlineRepoMock.delete, 1, [collection, undefined]);
           });
       });
 

diff --git a/test/integration/tests/sync.test.js b/test/integration/tests/sync.test.js
@@ -415,6 +415,31 @@ function testFunc() {
               .catch(done);
           });
 
+          it('should delete entities locally that are deleted in the server with autopagination', (done) => {
+            let query = new Kinvey.Query();
+            storeToTest.pull(query, {autoPagination:{pageSize:1}})
+              .then((result) => validatePullOperation(result, [entity1, entity2]))
+              .then(() => networkStore.save(entity3))
+              .then(() => storeToTest.pull(query, {autoPagination:true}))
+              .then((result) => validatePullOperation(result, [entity1, entity2, entity3]))
+              .then(() => networkStore.removeById(entity1._id))
+              .then(() => networkStore.removeById(entity2._id))
+              .then(() => storeToTest.pull(query, {autoPagination:true}))
+              .then((result) => validatePullOperation(result, [entity3]))
+              .then(() => {
+              let onNextSpy = sinon.spy();
+              syncStore.find()
+                  .subscribe(onNextSpy, done, () => {
+                      try {
+                          utilities.validateReadResult(Kinvey.DataStoreType.Sync, onNextSpy, [entity3])
+                          done();
+                      } catch (error) {
+                          done(error)
+                      }})
+            })
+            .catch(done);
+          });
+
           it('should pull only the entities, matching the query', (done) => {
             const query = new Kinvey.Query();
             query.equalTo('_id', entity1._id);