Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Updated simple test models to glTF 2.0 #45

Merged
merged 7 commits into from
May 20, 2017

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Apr 11, 2017

Most of the test models have been updated to 2.0. They may have to be reviewed, but in general, they should be compliant to the spec. A validation might reveal details that have to be fixed.

Only the AdvancedMaterial, SimpleOpacity and SimpleSkin model updates are still pending. These updates will depend on the MaterialCommon extension and the latest changes of skinning, which are not integrated yet.

For AdvancedMaterial, SimpleOpacity and SimpleSkin, the
update is sill pending (and indicated by a prominent
note in the README). They will be updated ASAP.
@pjcozzi
Copy link
Member

pjcozzi commented Apr 12, 2017

@lexaknyazev about when do you think the validator will be ready for us to test these?

@javagl
Copy link
Contributor Author

javagl commented Apr 12, 2017

No haste - Alexey is probably busy with more urgent tasks right now. I'll also review the models again ASAP, which goes hand in hand with checking the spec changes. The "big" changes actually affect the models that are not updated yet (materials and skinning), and I'll try to create further test models (morphing, sparse accessors...), so there's still a lot of work to do to consolidate all this anyhow.

@pjcozzi
Copy link
Member

pjcozzi commented May 3, 2017

Fixes most of #53, see #53 (comment).

@cx20
Copy link
Contributor

cx20 commented May 16, 2017

@javagl Is the position attribute of SimpleMaterial.gltf in this PR correct?
It doesn't seem to have a parameter corresponding to position attribute.

https://github.com/javagl/glTF-Sample-Models/blob/master/2.0/SimpleMaterial/glTF/SimpleMaterial.gltf#L86-L110

/cc @takahirox

Relate : mrdoob/three.js#11326 (comment)

@javagl
Copy link
Contributor Author

javagl commented May 16, 2017

@cx20 That's hard to say. It may not be correct. I think it once was correct. At least, once it was supposed to be correct (in the future) : KhronosGroup/glTF#789 (comment)

The KHR_technique_webgl extension is not finalized, and the SimpleMaterial model explicitly declared to be not updated yet. But I'll simply remove this model, having it in there does not make sense.

@lexaknyazev
Copy link
Member

@javagl
Couple fixes before merging:

@lexaknyazev lexaknyazev merged commit 2f92b0a into KhronosGroup:master May 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants