Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Update sample models to 2.0, add validator script #37

Closed

Conversation

stevenvergenz
Copy link

@stevenvergenz stevenvergenz commented Mar 17, 2017

I'm working on updating the 2.0 model samples to the latest spec revision. To aid in this effort, I've written a little JSON schema validator script, thought I may as well check it in.

Models to go:

  • AdvancedMaterial (plain)
  • AdvancedMaterial (binary)
  • AnimatedTriangle (plain)
  • AnimatedTriangle (binary)
  • BoomBox (plain)
  • BoomBox (binary)
  • BoomBox (spec-glossy)
  • Cameras (plain)
  • Cameras (binary)
  • Corset (plain)
  • Corset (binary)
  • Corset (spec-glossy)
  • Lantern (plain)
  • Lantern (binary)
  • Lantern (spec-glossy)
  • SimpleMaterial (plain)
  • SimpleMaterial (binary)
  • SimpleMeshes (plain)
  • SimpleMeshes (binary)
  • SimpleOpacity (plain)
  • SimpleOpacity (binary)
  • SimpleSkin (plain)
  • SimpleSkin (binary)
  • SimpleTexture (plain)
  • SimpleTexture (binary)
  • Triangle (plain)
  • Triangle (binary)
  • TriangleWithoutIndices (plain)
  • TriangleWithoutIndices (binary)

@pjcozzi
Copy link
Member

pjcozzi commented Mar 17, 2017

@stevenvergenz thanks for your effort here, could you please coordinate this work with:

@javagl
Copy link
Contributor

javagl commented Mar 17, 2017

I feel responsible for the "Simple" models, and I intended to update them manually: These are the models that are used in the tutorial, and I wanted to make sure that the properties are grouped conceptually and ordered sensibly, roughly matching the sections of the tutorial.

Actually, some of the "Simple" models have already been updated to the state of 2.0 (as it was, back then), in https://github.com/javagl/gltfTutorialModels/tree/2.0 . The simple models that still have to be updated are only

  • AdvancedMaterial
  • SimpleOpacity
  • SimpleSkin

They involved elements (materials and skins) that are not yet finalized.

I'll try to update them ASAP, and issue a PR here.

The other simple models still have to be revieved carefully, to make sure that they would pass a 2.0 validation.

(Of course, I locally also created a .BATch script to simply run the validator over all sample models. But as far as I know, the validator is not updated for 2.0 yet, and think that it will involve quite some efforts. Particularly, I wonder how KhronosGroup/glTF-Validator#1 will eventually be tackled).

@javagl
Copy link
Contributor

javagl commented Mar 17, 2017

(And a side note: In the context of https://github.com/javagl/JglTF/ , I also created a 1.0 -> 2.0 converter that translates a 1.0 asset into one that is supposed to be 2.0+techniqueExtension - but the latter is in a too early state to be sure that the conversion result makes sense. It worked for some of the original sample models, though - maybe I'll add it as part of another preview release of the jgltf-browser)

@stevenvergenz
Copy link
Author

@pjcozzi That validator is exactly what I was looking for before, thank you! Strange that I couldn't find it.

@javagl If you're willing to update these instead of me, that's fine by me! I had assumed they were forgotten, as there are no issues or pull requests to update them. Even if the updates are only in progress, it'd be great if you opened the PR, just so people can find them.

The only models I need right now are the animation and skinned mesh examples. I'm working on adding support for those in https://github.com/robertlong/UnityGLTFLoader, and I can't find any tools to generate something myself.

@lexaknyazev
Copy link
Member

@stevenvergenz @pjcozzi
I'm going to push 2.0 Validator update this weekend.

@bghgary
Copy link
Contributor

bghgary commented Mar 17, 2017

@lexaknyazev Do you mind working with @BeardedGnome on the 2.0 validator work? He has already started this: BeardedGnome/glTF-Validator#1

@pjcozzi
Copy link
Member

pjcozzi commented Mar 17, 2017

Wow, you all are moving fast on glTF! I dig it!

@javagl
Copy link
Contributor

javagl commented Apr 11, 2017

@stevenvergenz Most of the simple test models are updated via #45 . If you don't mind, I'd put the checkmarks into the list of you initial PR. (Merging them both might create conflicts, but this should only affect the AnimatedTriangle (plain) one, and I'd resolve them if necessary).

@pjcozzi
Copy link
Member

pjcozzi commented Jun 22, 2017

I believe this is OBE (overcome by events) now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants