Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFCI] Prepare for non-instrinsic debug info #2362

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

MrSidims
Copy link
Contributor

For now just convert BB with convertFromNewDbgValues, will figure out something smarter a bit later.

I've updated several tests with dbg.declare intrinsic adding --experimental-debuginfo-iterators=1 to check if it works.

Resolved #2357 for now

For now just convert BB with convertFromNewDbgValues, will
figure out something smarter a bit later.

I've updated several tests with dbg.declare intrinsic
adding --experimental-debuginfo-iterators=1 to check if it works.

Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author

FYI @jsji

@MrSidims
Copy link
Contributor Author

@vmaksimo @LU-JOHN please take a look

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for unblocking our testing. But we will need to handle new debug info. Also, we might need to figure out how to handle this in the reverse translator.
Thanks @MrSidims for a very quick resolution here.

@MrSidims
Copy link
Contributor Author

MrSidims commented Feb 14, 2024

But we will need to handle new debug info.

Well, basically we need to remove dbg_decl/var handling by having a case in intrinsic switch and replace it with something. AFAIU there are 2 options:

  1. Check associated debug info with alloca's to obtain dbg_decl/var, but it didn't work for me with a single attempt I made there;
  2. Smart iteration over a basic block, to get gdb_decl/var like described here: https://discourse.llvm.org/t/rfc-instruction-api-changes-needed-to-eliminate-debug-intrinsics-from-ir/68939/12 . That is slightly more work, as we would need to rewrite a little bit of code here.

Also, we might need to figure out how to handle this in the reverse translator.

Probably nothing to do there.

Copy link
Member

@svenvh svenvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@MrSidims MrSidims merged commit 0e87aef into KhronosGroup:main Feb 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DebugInfo] Support non-instrinsic debug-info
3 participants