-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Use unordered_map for better performance #2356
Conversation
0ee91f5
to
c32ab5d
Compare
I'm expecting, that lots of test would need to be updated, as order of IDs wouldn't remain after it. We would also need to check, if new order of IDs makes sense. PS DebugInfo failures are related to #2357 . You may want to incorporate #2362 for testing |
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
abeda5b
to
89cb624
Compare
I've incorporated #2362. I think I've avoided changing maps that will affect the output order. |
Please take a look @asudarsa @bwlodarcz @MrSidims |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively approving, but would be nice to have some numbers for performance improvements.
While in most cases it's LGTM, yet it's less obvious, that it improves std::string key cases.
@MrSidims It's valid improvement on algorithmic level but won't be visible in performance metrics due that other things (getEntry chain) are dominating execution time. Still, the gain is here. |
Use unordered_map instead of map for better performance.