Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up spec versions for win32 #1193

Conversation

nikhiljnv
Copy link
Contributor

Update external_memory_win32_name_handle with latest
updates from main.

Bump up spec versions for
cl_khr_external_memory_win32 from 1.0.0 to 1.1.0
and cl_khr_external_semaphore_win32 from 0.9.0 to 0.9.1

bashbaug and others added 5 commits May 20, 2024 21:39
This extension adds the revision field to the
XML tag for extensions. This allows a version
macro to be generated with:

* KhronosGroup/OpenCL-Headers#251
* KhronosGroup/OpenCL-Headers#248

KHR extensions are given a revision based on the semantic
version of the spec. However other extensions don't use
semantic versioning, and so are given a placeholder `0.0.0`
value until they can be updated by the owner.

The XML schema is also updated to make the revision field
mandatory in the XML entry for extensions and the
existence of the macro this enables is advertised to users
in the spec.
Links were not created for commands defined by extensions. With this
changes all uses of e.g. {clCreateSemaphoreWithPropertiesKHR} link
to the definition of the command which makes navigating the specification
much easier.


Change-Id: I4a9458609f4ba3229b66e3d169a68cb4564e2538

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Update  external_memory_win32_name_handle with latest
updates from main.
Bump up spec versions for
cl_khr_external_memory_win32 from 1.0.0 to 1.1.0
and cl_khr_external_semaphore_win32 from 0.9.0 to 0.9.1
@nikhiljnv nikhiljnv merged commit ff38d4d into external_memory_win32_name_handle Jun 27, 2024
1 of 3 checks passed
bashbaug added a commit that referenced this pull request Sep 3, 2024
* Add mechanism to specify named win32 NT handles

Currently, cl_khr_external_semaphore and cl_khr_external_memory define properties
to specify external win32 NT handle via pointer. Win32 NT handles can also be specified
via named strings.

Add properties to specify external Win32 NT handles via named strings too.

Fixes #943

* Updates to win32 named handle type changes. (#1180)

Address review comments.

Fixes #943

* Drop NULL from named win32 handle description (#1187)

* Updates to win32 named handle type changes.

Address review comments.

Fixes #943

* Drop NULL from named win32 handle description.

Address review comments from Ben to remove NULL
from named win32 handle description.

Fixes #943

* Bump up spec versions for win32 (#1193)

Bump up spec versions for
cl_khr_external_memory_win32 from 1.0.0 to 1.1.0
and cl_khr_external_semaphore_win32 from 0.9.0 to 0.9.1

* fix typo and add OPAQUE_WIN32_NAME_KHR to semaphore enums list

* Update opencl_runtime_layer.asciidoc

 Fix typo during conflict resolution opencl_runtime_layer.asciidoc.

---------

Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants