Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing external memory via named NT handle reference along with pointer reference #943

Closed
nikhiljnv opened this issue Jun 23, 2023 · 0 comments · Fixed by KhronosGroup/OpenCL-CTS#1895 or #1177
Closed

Importing external memory via named NT handle reference along with pointer reference #943

nikhiljnv opened this issue Jun 23, 2023 · 0 comments · Fixed by KhronosGroup/OpenCL-CTS#1895 or #1177

Comments

@nikhiljnv
Copy link
Contributor

cl_khr_external_memory
allows importing external memory specified via NT handle through CL_EXTERNAL_MEMORY_HANDLE_OPAQUE_WIN32_KHR
The spec says "CL_EXTERNAL_MEMORY_HANDLE_OPAQUE_WIN32_KHR specifies an NT handle ..."
This is mostly assuming reference to external memory is specified via void* NT handle pointer.
However, NT handle references can also be specified via named string.

This issue tracks discussion wrt supporting named NT handle references.
nikhiljnv added a commit that referenced this issue Nov 21, 2023
@nikhiljnv
Add mechanism to specify named win32 NT handles.
a4575e1 
Currently, cl_khr_external_semaphore and cl_khr_external_memory
define properties to specify external win32 NT handle via pointer.
Win32 NT handles can also be specified via named strings.
Add properties to specify external Win32 NT handles via named strings too.

Fixes #943
@nikhiljnv nikhiljnv mentioned this issue Nov 21, 2023
Closed
@saurabhnv saurabhnv mentioned this issue Feb 17, 2024
Merged
nikhiljnv added a commit that referenced this issue May 21, 2024
@nikhiljnv
Add mechanism to specify named win32 NT handles
3042bc1 
Currently, cl_khr_external_semaphore and cl_khr_external_memory define properties
to specify external win32 NT handle via pointer. Win32 NT handles can also be specified
via named strings.

Add properties to specify external Win32 NT handles via named strings too.

Fixes #943
@nikhiljnv nikhiljnv mentioned this issue May 21, 2024
Merged
nikhiljnv added a commit that referenced this issue Jun 11, 2024
@nikhiljnv
Updates to win32 named handle type changes.
228a277 
Address review comments.

Fixes #943
@nikhiljnv nikhiljnv mentioned this issue Jun 11, 2024
Merged
nikhiljnv added a commit that referenced this issue Jun 11, 2024
@nikhiljnv
Updates to win32 named handle type changes. (#1180)
a718db6 
Address review comments.

Fixes #943
nikhiljnv added a commit that referenced this issue Jun 18, 2024
@nikhiljnv
Drop NULL from named win32 handle description.
1798f7c 
Address review comments from Ben to remove NULL
from named win32 handle description.

Fixes #943
@nikhiljnv nikhiljnv mentioned this issue Jun 18, 2024
Merged
nikhiljnv added a commit that referenced this issue Jun 18, 2024
@nikhiljnv
Drop NULL from named win32 handle description. (#1184)
3b7cd1c 
Address review comments from Ben to remove NULL
from named win32 handle description.

Fixes #943
nikhiljnv added a commit that referenced this issue Jun 18, 2024
@nikhiljnv
Merge branch 'external_memory_win32_name_handle_3' into HEAD
a234742 
Latest updates to drop NULL from named handle type description.

Fixes #943
@nikhiljnv nikhiljnv mentioned this issue Jun 18, 2024
Merged
nikhiljnv added a commit that referenced this issue Jun 18, 2024
@nikhiljnv
Drop NULL from named win32 handle description (#1187)
348d8a5 
* Updates to win32 named handle type changes.

Address review comments.

Fixes #943

* Drop NULL from named win32 handle description.

Address review comments from Ben to remove NULL
from named win32 handle description.

Fixes #943
joshqti pushed a commit to KhronosGroup/OpenCL-CTS that referenced this issue Nov 5, 2024
@saurabhnv
Import Vulkan resources via named NT handle (#1895)
ef73a1d 
Add coverage to import Vulkan resources (memory and semaphore) in
Windows via named NT handles.
If no name is given during resource creation, then use NT handles for
import.
If a name is given, have an option to either use that name or get the NT
handle and use that for import.
Resolves KhronosGroup/OpenCL-Docs#943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nikhiljnv