Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some events are not released in test_mem_host_flags #2104

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Some events are not released in test_mem_host_flags #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions test_conformance/mem_host_flags/checker_mem_host_no_access.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,9 @@ cl_int cBuffer_check_mem_host_no_access<T>::Setup_Test_Environment()
template <class T>
cl_int cBuffer_check_mem_host_no_access<T>::verify_RW_Buffer()
{
cl_event event;
cl_int err = clEnqueueReadBuffer(
this->m_queue, this->m_buffer, this->m_blocking, 0,
this->get_block_size_bytes(), this->host_m_1.pData, 0, NULL, &event);
this->get_block_size_bytes(), this->host_m_1.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand All @@ -102,7 +101,7 @@ cl_int cBuffer_check_mem_host_no_access<T>::verify_RW_Buffer()

err = clEnqueueWriteBuffer(this->m_queue, this->m_buffer, this->m_blocking,
0, this->get_block_size_bytes(),
this->host_m_1.pData, 0, NULL, &event);
this->host_m_1.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand All @@ -125,14 +124,13 @@ template <class T>
cl_int cBuffer_check_mem_host_no_access<T>::verify_RW_Buffer_rect()
{
this->Init_rect();
cl_event event;
cl_int err = CL_SUCCESS;
err = clEnqueueReadBufferRect(
this->m_queue, this->m_buffer, this->m_blocking,
this->buffer_origin_bytes, this->host_origin_bytes, this->region_bytes,
this->buffer_row_pitch_bytes, this->buffer_slice_pitch_bytes,
this->host_row_pitch_bytes, this->host_slice_pitch_bytes,
this->host_m_2.pData, 0, NULL, &event);
this->host_m_2.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand All @@ -153,7 +151,7 @@ cl_int cBuffer_check_mem_host_no_access<T>::verify_RW_Buffer_rect()
this->buffer_origin_bytes, this->host_origin_bytes, this->region_bytes,
this->buffer_row_pitch_bytes, this->buffer_slice_pitch_bytes,
this->host_row_pitch_bytes, this->host_slice_pitch_bytes,
this->host_m_2.pData, 0, NULL, &event);
this->host_m_2.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand All @@ -175,13 +173,12 @@ cl_int cBuffer_check_mem_host_no_access<T>::verify_RW_Buffer_rect()
template <class T>
cl_int cBuffer_check_mem_host_no_access<T>::verify_RW_Buffer_mapping()
{
cl_event event;
cl_int err;

void *dataPtr;
dataPtr = clEnqueueMapBuffer(
this->m_queue, this->m_buffer, this->m_blocking, CL_MAP_READ, 0,
this->get_block_size_bytes(), 0, NULL, &event, &err);
this->get_block_size_bytes(), 0, NULL, NULL, &err);
if (err == CL_SUCCESS)
{
log_error("Calling clEnqueueMapBuffer (CL_MAP_READ) on a memory object "
Expand All @@ -206,7 +203,7 @@ cl_int cBuffer_check_mem_host_no_access<T>::verify_RW_Buffer_mapping()

dataPtr = clEnqueueMapBuffer(
this->m_queue, this->m_buffer, this->m_blocking, CL_MAP_WRITE, 0,
this->get_block_size_bytes(), 0, NULL, &event, &err);
this->get_block_size_bytes(), 0, NULL, NULL, &err);
if (err == CL_SUCCESS)
{
log_error("Calling clEnqueueMapBuffer (CL_MAP_WRITE) on a memory "
Expand Down
6 changes: 3 additions & 3 deletions test_conformance/mem_host_flags/checker_mem_host_read_only.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ cl_int cBuffer_check_mem_host_read_only<T>::verify_RW_Buffer()
// test write
err = clEnqueueWriteBuffer(this->m_queue, this->m_buffer, this->m_blocking,
0, this->get_block_size_bytes(),
this->host_m_2.pData, 0, NULL, &event);
this->host_m_2.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand Down Expand Up @@ -211,7 +211,7 @@ cl_int cBuffer_check_mem_host_read_only<T>::verify_RW_Buffer_rect()
this->buffer_origin_bytes, this->host_origin_bytes, this->region_bytes,
this->buffer_row_pitch_bytes, this->buffer_slice_pitch_bytes,
this->host_row_pitch_bytes, this->host_slice_pitch_bytes,
this->host_m_2.pData, 0, NULL, &event);
this->host_m_2.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand Down Expand Up @@ -270,7 +270,7 @@ cl_int cBuffer_check_mem_host_read_only<T>::verify_RW_Buffer_mapping()
// test blocking map read
clEnqueueMapBuffer(this->m_queue, this->m_buffer, this->m_blocking,
CL_MAP_WRITE, 0, this->get_block_size_bytes(), 0, NULL,
&event, &err);
NULL, &err);

if (err == CL_SUCCESS)
{
Expand Down
6 changes: 3 additions & 3 deletions test_conformance/mem_host_flags/checker_mem_host_write_only.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ cl_int cBuffer_check_mem_host_write_only<T>::verify_RW_Buffer()

err = clEnqueueReadBuffer(this->m_queue, this->m_buffer, CL_TRUE, 0,
this->get_block_size_bytes(),
this->host_m_2.pData, 0, NULL, &event);
this->host_m_2.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand Down Expand Up @@ -257,7 +257,7 @@ cl_int cBuffer_check_mem_host_write_only<T>::verify_RW_Buffer_rect()
this->buffer_origin_bytes, this->host_origin_bytes, this->region_bytes,
this->buffer_row_pitch_bytes, this->buffer_slice_pitch_bytes,
this->host_row_pitch_bytes, this->host_slice_pitch_bytes,
this->host_m_2.pData, 0, NULL, &event);
this->host_m_2.pData, 0, NULL, NULL);

if (err == CL_SUCCESS)
{
Expand Down Expand Up @@ -349,7 +349,7 @@ cl_int cBuffer_check_mem_host_write_only<T>::verify_RW_Buffer_mapping()
// test map read
clEnqueueMapBuffer(this->m_queue, this->m_buffer, this->m_blocking,
CL_MAP_READ, 0, this->get_block_size_bytes(), 0, NULL,
&event, &err);
NULL, &err);

if (err == CL_SUCCESS)
{
Expand Down
Loading