Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some events are not released in test_mem_host_flags #2104

Merged

Conversation

aharon-abramson
Copy link
Contributor

In test_mem_host_flags, some events are not released. In fact, they are not used, so they can be removed altogether.

n test_mem_host_flags some events are not released. In fact, they are not used, so they can be removed altogether.
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, and I'm fine checking this in as-is, but it looks like there are still some unreleased events. Using the OpenCL Intercept Layer and LeakChecking, here is the report before this change:

No cl_context leaks detected.
No cl_command_queue leaks detected.
No cl_mem leaks detected.
Possible leak of type cl_event!
    Number of Allocations: 672
    Number of Retains:     0
    Number of Releases:    336

And after:

No cl_context leaks detected.
No cl_command_queue leaks detected.
No cl_mem leaks detected.
Possible leak of type cl_event!
    Number of Allocations: 432
    Number of Retains:     0
    Number of Releases:    336

Let me know if you 'd like help tracking down some of the remaining leaks.

@bashbaug
Copy link
Contributor

Merging as discussed in the October 22nd teleconference. We will address the remaining leaks in a subsequent PR.

@bashbaug bashbaug merged commit 482a6bc into KhronosGroup:main Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants