Keyboard resize fix #341
Merged
Keyboard resize fix #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spodi
force-pushed
the
keyboard-resize-fix
branch
from
184bf19 to
3c84f17
Compare
|
I can do a follow up if it is wished that the game keeps running like before. That however brings the laggy/stutter move/resize back. (Although not that back and forth with keyboard this fixes!) |
Kenix3
approved these changes
Sep 21, 2023
Hm I think I need to change it so it only closes on true. And sry I accidentally tapped "close PR" while typing this on my phone 😑 |
|
Can you rebase on the latest master? Thankyou. |
Use the function that was already there for the message queue and just run dxgi.run_one_game_iter() in a loop. This should be more in line with how this works in SDL/OpenGL. Fixes bugged (jittery) resize/move with keyboard through the window menu. Although the game pauses when moved/resized or the window menu is open (also like in SDL/OpenGL).
Spodi
force-pushed
the
keyboard-resize-fix
branch
from
04692e6 to
0238a81
Compare
Done |
KiritoDv
pushed a commit
to KiritoDv/libultraship
that referenced
this pull request
Oct 6, 2023
* Move run_one_game_iter() out of WM_PAINT Use the function that was already there for the message queue and just run dxgi.run_one_game_iter() in a loop. This should be more in line with how this works in SDL/OpenGL. Fixes bugged (jittery) resize/move with keyboard through the window menu. Although the game pauses when moved/resized or the window menu is open (also like in SDL/OpenGL). * Fixed game never stopped running after last commit * Attempt to gracefully close on logout * Only close if endsession is not canceled
Spodi
added a commit
to Spodi/libultraship
that referenced
this pull request
Nov 12, 2023
This seems to have caused a discrepancy in DPI awareness and therefore ImGUI does not use the whole window.
Kenix3
pushed a commit
that referenced
this pull request
Nov 14, 2023
briaguya-ai
pushed a commit
to briaguya-ai/libultraship
that referenced
this pull request
Nov 19, 2023
This seems to have caused a discrepancy in DPI awareness and therefore ImGUI does not use the whole window.
Kenix3
pushed a commit
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the function that was already there for the message queue and just run dxgi.run_one_game_iter() in a loop. This should be more in line with how this works in SDL/OpenGL.
Fixes bugged (jittery) resize/move with keyboard through the window menu. Although the game pauses when moved/resized or the window menu is open (also like in SDL/OpenGL).
Before:
https://github.com/Kenix3/libultraship/assets/962946/c2e9f37c-31f8-4d32-ad3e-0f595faf40c8
After the changes:
https://github.com/Kenix3/libultraship/assets/962946/d6b3afdd-a53a-4771-a1e5-ea2c098ae5f8