Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PulseAudioPlayer #311

Closed
briaguya-ai opened this issue Jun 9, 2023 · 3 comments
Closed

Remove PulseAudioPlayer #311

briaguya-ai opened this issue Jun 9, 2023 · 3 comments
Labels
deprecation proposal This feature should be deprecated from the API

Comments

@briaguya-ai
Copy link
Collaborator

SDL provides a great abstraction layer for audio. https://github.com/Kenix3/libultraship/blob/main/src/audio/SDLAudioPlayer.cpp accomplishes in 44 lines what takes https://github.com/Kenix3/libultraship/blob/main/src/audio/PulseAudioPlayer.cpp 191.

SDL supports many different audio drivers https://wiki.libsdl.org/SDL2/FAQUsingSDL#linux_1 (including pulseaudio)

I propose we remove PulseAudioPlayer and rely on SDL audio for linux instead.
@briaguya-ai briaguya-ai added the deprecation proposal This feature should be deprecated from the API label Jun 9, 2023
@briaguya-ai briaguya-ai changed the title Deprecation Proposal: Remove PulseAudioPlayer Remove PulseAudioPlayer Jun 9, 2023
@Kenix3
Copy link
Owner

Kenix3 commented Jun 9, 2023

Seems good to me. I think marking it as deprecated in the next release, and removing it in the next major release makes sense here.
Will leave this open for comments before accepting the proposal until June 21st.

@vanfanel
Copy link
Contributor

vanfanel commented Jun 9, 2023 •
edited
Loading

Builds and works well for me after removing pulseaudio manually.

Kenix3 added a commit that referenced this issue Oct 9, 2023
@Kenix3
Removes Pulse Audio. Config values will be migrated to sdl audio back…
0623d97 
…end.

#311
@Kenix3 Kenix3 mentioned this issue Oct 9, 2023
Merged
Kenix3 added a commit that referenced this issue Oct 10, 2023
@Kenix3
Removes Pulse Audio. Config values will be migrated to sdl audio back…
8fb8711 
… end. (#356)

* Removes Pulse Audio. Config values will be migrated to sdl audio backend.

#311

* Removes PulseAudio.h from classes.h
@Kenix3
Copy link
Owner

Kenix3 commented Oct 10, 2023

Implemented in next branch for 2.0.0

@Kenix3 Kenix3 closed this as completed Oct 10, 2023
briaguya-ai pushed a commit to briaguya-ai/libultraship that referenced this issue Nov 7, 2023
@Kenix3 @briaguya-ai
Removes Pulse Audio. Config values will be migrated to sdl audio back…
49c302d 
… end. (Kenix3#356)

* Removes Pulse Audio. Config values will be migrated to sdl audio backend.

Kenix3#311

* Removes PulseAudio.h from classes.h
Kenix3 added a commit that referenced this issue Nov 7, 2023
@briaguya-ai @Kenix3
Removes Pulse Audio. Config values will be migrated to sdl audio back…
c6ac929 
… end. (#356) (#362)

* Removes Pulse Audio. Config values will be migrated to sdl audio backend.

#311

* Removes PulseAudio.h from classes.h

Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com>
Kenix3 added a commit that referenced this issue Feb 8, 2024
@Kenix3 @briaguya-ai
Refactors Archive class to have an ArchiveManager (#422)
825bd12 
* Removes Pulse Audio. Config values will be migrated to sdl audio backend.

#311

* Removes PulseAudio.h from classes.h

* Refactors archives to have a separate manager class.

* Run clang-format

* Includes string in ResourceType.h

* Only include tchar.h in Context.cpp when building for Windows.

* Includes vector in ArchiveManager.h

* fix: put `SDL_WndProc` behind `_WIN32` ifdef (#423)

* Fix issues with Archive refactor (#424)

* get in game

* clang format

* windows build

* pr comments

* return false

* uncomment

* fix fonts

* pr comment

* init dadon't

* raw

* Fixes issue where ArchiveManager never unloads Archives.

* Fixes builds for StormLib issues. (#425)

* this is a stupid hack but i'm too tired to keep trying to figure out how we're linking everything

* link?

* ports...

* windows?

---------

Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation proposal This feature should be deprecated from the API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vanfanel @Kenix3 @briaguya-ai