Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to authenticate using client ID #257

Merged
merged 11 commits into from
Nov 18, 2021
Merged

Ability to authenticate using client ID #257

merged 11 commits into from
Nov 18, 2021

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Nov 18, 2021

Prerequisites

If checks are not passed then the pull request will be closed.

  • I have checked that no other similar pull request already exists.
  • My code follows the general code style as the rest of the code.
  • I have checked that no sensitive information is exposed.
  • Build compiles.
  • Build passes test cases.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Workflow Run

https://github.com/Katsute/Mal4J/actions/runs/1478373853

Changes Made

List any changes made and/or other relevant issues.

  • Add ability to authenticate with client ID only MAL no longer requires OAuth2 auth for read-only operations #256
  • Throw exception on write operations when there is no token
  • Change MyAnimeList.withOAuthToken(String) to MyAnimeList.withToken(String)
  • [DEPRECATED] Deprecate MyAnimeList.withOAuthToken(String)
  • Change MyAnimeList.refreshOAuthToken() to MyAnimeList.refreshToken()
  • [DEPRECATED] Deprecate MyAnimeList.refreshOAuthToken()
  • [TESTS] Update test matrix to run client and token tests
  • [TESTS] Update MAL test provider
  • [TESTS] SKIP write/private tests on client tests
  • [TESTS] ADD tests for client ID
  • [DOCS] Documentation ordering tweaks
  • [DOCS] Update setup guide
  • [DOCS] Update FAQ
  • [DOCS] Update README

@Katsute Katsute changed the title Ability to authenticate using ONLY client ID Ability to authenticate using client ID Nov 18, 2021
@Katsute Katsute merged commit b1ebebd into main Nov 18, 2021
@Katsute Katsute deleted the client-auth@c009b19 branch November 18, 2021 21:34
@ghost ghost locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant