Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAL no longer requires OAuth2 auth for read-only operations #256

Closed
5 tasks done
Katsute opened this issue Nov 18, 2021 · 4 comments
Closed
5 tasks done

MAL no longer requires OAuth2 auth for read-only operations #256

Katsute opened this issue Nov 18, 2021 · 4 comments
Assignees
@Katsute
Labels
feature request MyAnimeList API
Milestone
2.6.0

Comments

@Katsute
Copy link
Member

Katsute commented Nov 18, 2021 •
edited
Loading

Prerequisites

  • I have checked that no other similar feature request already exists.
  • I have checked discussions.
  • This feature request makes sense for the project.
  • I have checked that this feature does not already exist.
  • I am running the latest release version.

Feature

For read-only operations the client id can be set in the X-MAL-CLIENT-ID header, without requiring OAuth2.

Todo:

  • Add new auth method that bypasses oauth2
  • Have exception when using write/private operation without oauth2
  • Check compatibility with client secret ✔ no secret required for read operations
  • Test cases for client header

Reason

See https://myanimelist.net/forum/?topicid=1973077&show=0#msg64957586
@Katsute Katsute added this to the 2.6.0 milestone Nov 18, 2021
@Katsute Katsute self-assigned this Nov 18, 2021
@Katsute Katsute mentioned this issue Nov 18, 2021
Closed
4 tasks
@Katsute
Copy link
Member Author

Katsute commented Nov 18, 2021

See https://myanimelist.net/forum/?topicid=1973141&show=0#msg64959633

@Katsute
Copy link
Member Author

Katsute commented Nov 18, 2021

@sinon-bot branch client auth

@ghost
Copy link

ghost commented Nov 18, 2021

New branch created client-auth@c009b19

This branch was created by @Katsute.

@Katsute Katsute mentioned this issue Nov 18, 2021
Merged
6 tasks
@Katsute
Copy link
Member Author

Katsute commented Nov 18, 2021

Closed in #257

@Katsute Katsute closed this as completed Nov 18, 2021
@ghost ghost locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Katsute Katsute

Labels
feature request MyAnimeList API
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
1 participant
@Katsute