Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executable Tutorial proposal: Integrate DataDog in existing app #972

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Executable Tutorial proposal: Integrate DataDog in existing app #972

merged 3 commits into from
Mar 25, 2021

Conversation

evkade
Copy link

@evkade evkade commented Mar 24, 2021

No description provided.

@khaes-kth khaes-kth self-requested a review March 25, 2021 12:56
@khaes-kth
Copy link

Hi @evkade ,
As I understand, you have added two topics in this single PR. Can you please close this PR and create two separate PRs each including one single topic proposal?

@khaes-kth khaes-kth self-assigned this Mar 25, 2021
@khaes-kth khaes-kth added the tutorial One of the task categories listed in README.md label Mar 25, 2021
@evkade
Copy link
Author

evkade commented Mar 25, 2021

Hi! Sorry I think the other file slipped through. Fixed it now!

khaes-kth
khaes-kth approved these changes Mar 25, 2021
View reviewed changes
Copy link

@khaes-kth khaes-kth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khaes-kth khaes-kth merged commit a242a67 into KTH:2021 Mar 25, 2021
@mans-andersson mans-andersson mentioned this pull request Mar 30, 2021
Merged
@majate majate mentioned this pull request Mar 30, 2021
Merged
@majate
Copy link

majate commented Mar 30, 2021 •
edited
Loading

@Sebberh and I will give feedback for this task and our feedback PR id is #1071

@evkade
Copy link
Author

evkade commented Apr 23, 2021

The tutorial is ready for review at https://www.katacoda.com/andreeva/scenarios/datadog-tutorial ! :)

@evkade evkade mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaes-kth khaes-kth khaes-kth approved these changes

Assignees

@khaes-kth khaes-kth

Labels
tutorial One of the task categories listed in README.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evkade @khaes-kth @majate