-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial submission (FINAL) #1330
Conversation
Good job! 🌟 @Sebberh and I have looked at your tutorial and written some feedback. We have tried to include all our thought, even if they regard minor details. Of course, you are free to decide if the comments are relevant to act upon or not. We have submitted the feedback in PR #1336, but I include a copy here as well. FeedbackOverall feedbackIn general, the tutorial was easy to follow, and no problems were encountered during the execution. Furthermore, the content was relevant, and the structure seemed thought trough. We especially liked that you included step 2 where one runs the application without DataDog. This step helps demonstrate how cumbersome logs can be and why DataDog is useful. However, some things could be explained further to give us reader a better understanding of what we do and how it works. If you feel that some explanations are outside the scope of the tutorial, it could also be an idea to link sources for readers who want to learn more. You might also want to add references to images you have not created yourself. Inconsistent languageFor some words/terms you are inconsistent regarding how you write them. Throughout the tutorial you mix between:
You are also inconsistent with the capitalization of your headers. For the majority of the headers, you only capitalize the first letter of the first word. However, in all headers in step 3 and in one header in step 5 you capitalize the first letter in all words. Even if these points do not make the tutorial less clear or easy to follow, it reduces the quality of the text in general. Introduction
Step 1
Step 2
Step 3
Step 4
Step 5
Congratulations
NitpicksThere was a couple of warnings during the demo:
|
Thank you @majate and @Sebberh for the feedback. It was very valuable! We have now updated the tutorial and finalized it. We created a commit in the Katacoda repository with all the changes we made. The commit can be found here: andrebrogard/katacoda-scenarios@4e1cc25 |
Thanks for the update! For a better trace of the tasks, we recommend one PR per task. Could you please remove the changes related to presentation? I can also remove it if you want. Thanks. |
@SophieHYe Sorry I did not see the extra changes before! If it is possible could you remove them? We had a lot of trouble with this previously also |
Hi, no worries, I have checked your presentation link is merged already. This happens because we merge your presentation PR before tutorial. It's recommend to use git cherry-pick to select one specific commit per PR. I am now merging your tutorial submission now. Thanks. |
Contributors
André Brogärd
Email: brogard@kth.se
Github: andrebrogard
Eva Despinoy
Email: despinoy@kth.se
Github: evkade
Changed proposal file to include the link of the finished tutorial.
PR of proposal: #972
PR of feedback: #1071
We aim for a remarkable grade! ⭐️