Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Once again allow users to select dependencies when multiple provides exist #1002

Merged
merged 12 commits into from
Jun 5, 2015
Merged

Once again allow users to select dependencies when multiple provides exist #1002

merged 12 commits into from
Jun 5, 2015
+510 −279

Commits on Jun 2, 2015

  1. Have user select provides when there are multiple choices. 

    Fixes KSP-CKAN#976
Pops up the moment the user chooses a mod instead of waiting until the install. This way there can be accurate change sets and conflict detection.
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    ed3bbc8 View commit details
    Browse the repository at this point in the history

  2. Change error dialog to user richtextbox 

    Allows scrolling the error message and easier copying.
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    055b4a9 View commit details
    Browse the repository at this point in the history

  3. Cancel button on provides selection screen. 

    Now works. It deselects the mod which caused the screen to pop up. Also adds a test.
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    0e64b6e View commit details
    Browse the repository at this point in the history

  4. Fix test.

    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    09ed973 View commit details
    Browse the repository at this point in the history

  5. Disallow multiple selections for provides on Linux. 

    Windows seems to fire ItemChecked on creation, Linux does not. As such all checkbox where selected on Linux leading to errors.
Fixes some of KSP-CKAN/CKAN-GUI#137 (comment)
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    5d81c6c View commit details
    Browse the repository at this point in the history

  6. Handle recursive too many provides better. 

    When a selected provide mod it self triggered to many provides the next screen's cancel button was incorrectly cancelling the original mod.
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    1e7b677 View commit details
    Browse the repository at this point in the history

  7. Catch ModuleNotFound and fix bug in select mod for install. 

    Select mod for install was working on the filtered list instead of the whole.
ModuleNotFound occurs because the registry's availablewithprovides happy returns mods which are not available. Long term fixing that would be the correct solution
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    9facd3b View commit details
    Browse the repository at this point in the history

  8. Attempt to fix the linux display issue.

    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    d918d8a View commit details
    Browse the repository at this point in the history

  9. Clear the last_mod_toggled stack. 

    Otherwise if a provides throws a InconsistentKraken the contents would leak.
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    aaeba8f View commit details
    Browse the repository at this point in the history

  10. Fix for test and build. 

    Seems await in catch is breaking things.
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    1bcfb4d View commit details
    Browse the repository at this point in the history

  11. Fix issue with uninstallable provides. 

    See KSP-CKAN/CKAN-GUI#137 (comment) for description
    @RichardLake
    RichardLake committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    4b5d3e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2015

  1. Fix enabled status of continue button in choose provides screen. 

    See KSP-CKAN#1002 (comment) for bug report.
    @RichardLake
    RichardLake committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    2cbcdf1 View commit details
    Browse the repository at this point in the history