Once again allow users to select dependencies when multiple provides exist #1002

RichardLake · 2015-05-31T08:31:11Z

Fixes #976.

See: KSP-CKAN/CKAN-GUI#137 for some discussion.

pjf · 2015-06-02T03:08:21Z

Cmdline/CKAN-cmdline.csproj

@@ -9,12 +9,15 @@
    <AssemblyName>CmdLine</AssemblyName>
    <StartupObject>CKAN.CmdLine.MainClass</StartupObject>
    <ApplicationIcon>..\GUI\assets\ckan.ico</ApplicationIcon>
+    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>


I'm guessing we didn't have a target framework before? What would it default to without this? (My mind says that we were targeting dotnet40, but I've no idea if that's actually true.)

I think the VS default is v4.0 but I'm not 100%

pjf · 2015-06-02T03:12:21Z

Core/Relationships/RelationshipResolver.cs

@@ -333,6 +334,15 @@ private void Add(CkanModule module, Relationship reason)
            }
        }

+        private bool MightBeInstallable(CkanModule module)


Some docs on this would be great.

It looks like we recursively chase all dependencies and make sure we can potentially install them all in some iteration. (Although we don't check against conflicts against currently installed mods, since MightBeInstallable vs AbsolutelyInstallable. :)

pjf · 2015-06-02T03:21:10Z

Under Linux with mono 3.2.8 and 21d2b98, I get a hard lock whenever I select anything that requires a choice to be made. The GUI completely stops responding, the window can't be closed, and I have to kill it from the command-line. :(

pjf · 2015-06-02T03:22:28Z

I can also reproduce the same lock-up under Mono 3.12.1 under Linux.

Fixes KSP-CKAN#976 Pops up the moment the user chooses a mod instead of waiting until the install. This way there can be accurate change sets and conflict detection.

Allows scrolling the error message and easier copying.

Now works. It deselects the mod which caused the screen to pop up. Also adds a test.

Windows seems to fire ItemChecked on creation, Linux does not. As such all checkbox where selected on Linux leading to errors. Fixes some of KSP-CKAN/CKAN-GUI#137 (comment)

When a selected provide mod it self triggered to many provides the next screen's cancel button was incorrectly cancelling the original mod.

Select mod for install was working on the filtered list instead of the whole. ModuleNotFound occurs because the registry's availablewithprovides happy returns mods which are not available. Long term fixing that would be the correct solution

Otherwise if a provides throws a InconsistentKraken the contents would leak.

Seems await in catch is breaking things.

See KSP-CKAN/CKAN-GUI#137 (comment) for description

pjf · 2015-06-03T08:00:32Z

Testing 4b5d3e4:

Selecting Astronomer’s Pack immediately gives me a choice of clouds. Hooray!
Selecting an option (eg High) and then selecting another without unticking the first does change my selection, but causes the continue button to grey out.
Unselecting an option and then re-selecting it causes the continue button to return to active behaviour.

This isn't a show-stopper (we're way better than we were before), so I'm continuing with review.

pjf · 2015-06-03T08:05:11Z

Same commit, but more serious bug:

Select Astronomer's Pack
Select a cloud pack (I picked low)
Note that we're back on the mod selection list, but there's no Changset tab, nor active "go to changes" button.

Selecting the cloud pack directly in the mod list does the right thing (gives me a change set with dependencies listed).

A more minor behavioural surprise (and also not a merge-blocker) is that if we untick the cloud pack we immediately get asked to choose a cloud pack. That's kind of cool (because it keeps consistency), but users may be surprised by it (eg: either expecting either for the dependant package to be unchosen, or for that to be an option that's presented).

Postremus · 2015-06-03T08:32:05Z

Outerplanetsmod shows a similar behaviour.
Dependencys are not listed, but instead immediatly installed.
You only see the dependencys in the install screen

----- Ursprüngliche Nachricht -----
Von: "Paul Fenwick" notifications@github.com
Gesendet: ‎03.‎06.‎2015 10:05
An: "KSP-CKAN/CKAN" CKAN@noreply.github.com
Betreff: Re: [CKAN] Once again allow users to select dependencies whenmultiple provides exist (#1002)

Same commit, but more serious bug:
Select Astronomer's Pack
Select a cloud pack (I picked low)
Note that we're back on the mod selection list, but there's no Changset tab, nor active "go to changes" button.
Selecting the cloud pack directly in the mod list does the right thing (gives me a change set with dependencies listed).
A more minor behavioural surprise (and also not a merge-blocker) is that if we untick the cloud pack we immediately get asked to choose a cloud pack. That's kind of cool (because it keeps consistency), but users may be surprised by it (eg: either expecting either for the dependant package to be unchosen, or for that to be an option that's presented).
—
Reply to this email directly or view it on GitHub.

See KSP-CKAN#1002 (comment) for bug report.

RichardLake · 2015-06-03T09:19:01Z

Selecting an option (eg High) and then selecting another without unticking the first does change my selection, but causes the continue button to grey out.

Fixed in 2cbcdf1

. ... (eg: either expecting either for the dependant package to be unchosen, or for that to be an option that's presented).

Long term idea is to continue towards making RelationshipResolver work with multiple calls instead of the current one-shot everything in ctor method. Once this and adding mods to the provider with reasons are in it should be possible to use the reasonFor functionality to extract which mod is the dependant package. At which point it would be easy to change the GUI behaviour.

Note that we're back on the mod selection list, but there's no Changset tab, nor active "go to changes" button.

:worksOnMyMachine:. I'll break out the linux VM and check if it is a mono/.Net difference and investigate.

RichardLake · 2015-06-03T09:25:05Z

Note that we're back on the mod selection list, but there's no Changset tab, nor active "go to changes" button.

Functioning on mono 4.0.1 from a empty install.

RichardLake · 2015-06-03T09:40:10Z

@pjf Can you replicate the missing changeset tab with a empty install?

pjf · 2015-06-05T06:47:43Z

Apologies for my absence over the last two days; life threw me a real curveball.

@pjf Can you replicate the missing changeset tab with a empty install?

I cannot. And after some tracking, I discovered that I have PlanetShine-Config-Default installed, which conflicts causes conflicts. Selecting just the cloud pack doesn't technically depend upon the parent Astronomer’s Pack, so no conflicts.

This is a fault in my testing. Hooray! :D

pjf · 2015-06-05T06:54:25Z

Merging every zig for great justice. :)

Once again allow users to select dependencies when multiple provides exist

RichardLake added Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN ★★☆ In progress We're still working on this pull request and removed In progress We're still working on this ★★☆ labels May 31, 2015

RichardLake force-pushed the UserProvidesSelect branch 5 times, most recently from a5fa0a4 to 90c751a Compare June 1, 2015 02:35

pjf changed the title ~~User provides select~~ Once again allow users to select dependencies when multiple provides exist Jun 2, 2015

pjf reviewed Jun 2, 2015
View reviewed changes

RichardLake force-pushed the UserProvidesSelect branch from 63054d2 to 21d2b98 Compare June 2, 2015 03:10

pjf reviewed Jun 2, 2015
View reviewed changes

RichardLake force-pushed the UserProvidesSelect branch from 21d2b98 to 6f1fcef Compare June 2, 2015 05:02

RichardLake added 9 commits June 2, 2015 16:09

Have user select provides when there are multiple choices.

ed3bbc8

Fixes KSP-CKAN#976 Pops up the moment the user chooses a mod instead of waiting until the install. This way there can be accurate change sets and conflict detection.

Change error dialog to user richtextbox

055b4a9

Allows scrolling the error message and easier copying.

Cancel button on provides selection screen.

0e64b6e

Now works. It deselects the mod which caused the screen to pop up. Also adds a test.

Fix test.

09ed973

Disallow multiple selections for provides on Linux.

5d81c6c

Windows seems to fire ItemChecked on creation, Linux does not. As such all checkbox where selected on Linux leading to errors. Fixes some of KSP-CKAN/CKAN-GUI#137 (comment)

Handle recursive too many provides better.

1e7b677

When a selected provide mod it self triggered to many provides the next screen's cancel button was incorrectly cancelling the original mod.

Attempt to fix the linux display issue.

d918d8a

Clear the last_mod_toggled stack.

aaeba8f

Otherwise if a provides throws a InconsistentKraken the contents would leak.

RichardLake added 2 commits June 2, 2015 16:12

Fix for test and build.

1bcfb4d

Seems await in catch is breaking things.

Fix issue with uninstallable provides.

4b5d3e4

See KSP-CKAN/CKAN-GUI#137 (comment) for description

RichardLake force-pushed the UserProvidesSelect branch from 6f1fcef to 4b5d3e4 Compare June 2, 2015 06:43

Fix enabled status of continue button in choose provides screen.

2cbcdf1

See KSP-CKAN#1002 (comment) for bug report.

pjf added a commit that referenced this pull request Jun 5, 2015

Merge pull request #1002 from RichardLake/UserProvidesSelect

c57dc8a

Once again allow users to select dependencies when multiple provides exist

pjf merged commit c57dc8a into KSP-CKAN:master Jun 5, 2015

pjf removed the pull request label Jun 5, 2015

RichardLake deleted the UserProvidesSelect branch June 5, 2015 07:00

Dazpoet mentioned this pull request Aug 24, 2015

Installing Realistic Progression Zero and Realism Overhaul does not pull in Real Solar System #1346

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Once again allow users to select dependencies when multiple provides exist #1002

Once again allow users to select dependencies when multiple provides exist #1002

RichardLake commented May 31, 2015

pjf Jun 2, 2015

RichardLake Jun 2, 2015

pjf Jun 2, 2015

pjf commented Jun 2, 2015

pjf commented Jun 2, 2015

pjf commented Jun 3, 2015

pjf commented Jun 3, 2015

Postremus commented Jun 3, 2015

RichardLake commented Jun 3, 2015

RichardLake commented Jun 3, 2015

RichardLake commented Jun 3, 2015

pjf commented Jun 5, 2015

pjf commented Jun 5, 2015

Once again allow users to select dependencies when multiple provides exist #1002

Once again allow users to select dependencies when multiple provides exist #1002

Conversation

RichardLake commented May 31, 2015

pjf Jun 2, 2015

Choose a reason for hiding this comment

RichardLake Jun 2, 2015

Choose a reason for hiding this comment

pjf Jun 2, 2015

Choose a reason for hiding this comment

pjf commented Jun 2, 2015

pjf commented Jun 2, 2015

pjf commented Jun 3, 2015

pjf commented Jun 3, 2015

Postremus commented Jun 3, 2015

RichardLake commented Jun 3, 2015

RichardLake commented Jun 3, 2015

RichardLake commented Jun 3, 2015

pjf commented Jun 5, 2015

pjf commented Jun 5, 2015