Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tests on mashnet-staging #373

Merged
merged 1 commit into from
Apr 20, 2021
Merged

ci: tests on mashnet-staging #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ jobs:

needs: check_skip

strategy:
matrix:
image: ['latest-develop', 'latest-rc']

steps:
- uses: actions/checkout@v1

Expand All @@ -80,7 +84,7 @@ jobs:
env:
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
ECR_REPOSITORY: kilt/prototype-chain
IMAGE_TAG: latest-develop
IMAGE_TAG: ${{ matrix.image }}
run: |
yarn install --immutable
yarn build
Comment on lines +87 to 90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building twice feels completely unnecessary, but as far as I can see there is no matrix strategy for a single step only - so I guess there is no way around it. But it's another argument to finally figure out a way to build once and use the wherever required (running example, integration testing, maybe even unit testing ?)

Expand All @@ -95,6 +99,10 @@ jobs:

needs: check_skip

strategy:
matrix:
image: ['latest-develop', 'latest-rc']

steps:
- uses: actions/checkout@v1

Expand All @@ -119,7 +127,7 @@ jobs:
env:
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
ECR_REPOSITORY: kilt/prototype-chain
IMAGE_TAG: latest-develop
IMAGE_TAG: ${{ matrix.image }}
run: |
yarn install --immutable
yarn build
Expand All @@ -134,6 +142,10 @@ jobs:

needs: check_skip

strategy:
matrix:
image: ['latest-develop', 'latest-rc']

steps:
- uses: actions/checkout@v1

Expand All @@ -158,7 +170,7 @@ jobs:
env:
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
ECR_REPOSITORY: kilt/prototype-chain
IMAGE_TAG: latest-develop
IMAGE_TAG: ${{ matrix.image }}
run: |
yarn install --immutable
yarn build
Expand Down