ci: tests on mashnet-staging #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechtner
approved these changes
Apr 20, 2021
Comment on lines
+87
to
90
| IMAGE_TAG: ${{ matrix.image }} | ||
| run: | | ||
| yarn install --immutable | ||
| yarn build |
There was a problem hiding this comment.
building twice feels completely unnecessary, but as far as I can see there is no matrix strategy for a single step only - so I guess there is no way around it. But it's another argument to finally figure out a way to build once and use the wherever required (running example, integration testing, maybe even unit testing ?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#1244
This PR runs integration tests / getting-started and example against the mashnet-staging network as well as the devnet
How to test:
Checklist: