feat: support for unique linking #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
commented
Nov 5, 2024
| // Flag specifying whether there should only ever be a single account <-> DID | ||
| // link, or multiple. | ||
| #[pallet::constant] | ||
| type UniqueLinkingEnabled: Get<bool>; |
There was a problem hiding this comment.
I made this a Get<bool> instead of a const to both allow clients to query whether this pallet enforces unique links or not, and to also make testing easier since this value can be dynamically mocked, as opposed to a const.
ntn-x2
force-pushed
the
aa/instantiatable-linking-pallet
branch
from
a872cc4 to
abf6587
Compare
ntn-x2
force-pushed
the
aa/linking-limit
branch
from
9d31e0e to
61ec5a2
Compare
ntn-x2
force-pushed
the
aa/instantiatable-linking-pallet
branch
from
abf6587 to
0514617
Compare
ntn-x2
force-pushed
the
aa/linking-limit
branch
from
61ec5a2 to
d5e79c7
Compare
ntn-x2
force-pushed
the
aa/instantiatable-linking-pallet
branch
from
0514617 to
84d3faf
Compare
ntn-x2
force-pushed
the
aa/linking-limit
branch
from
d5e79c7 to
21e97e7
Compare
Ad96el
previously approved these changes
Nov 6, 2024
ntn-x2
added a commit
that referenced
this pull request
Nov 6, 2024
Part of KILTprotocol/ticket#3650, built on top of #782. I left a few comments on the review to help the reviewer understanding the context of this changeset. ## Checklist - [x] Add dotnames pallet to both runtimes - [x] Add second linking deployment with unique linking to both runtimes - [ ] ~Add new runtime API for batch resolution to both runtimes~ -> will do in a separate PR along with a new runtime API for unique linking resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/KILTprotocol/ticket/issues/3650. Built on top of #781.
Trade-off
I chose to go this way instead of providing an optional counter, because providing a counter would require one of the following two approaches:
Hence, the solution was to provide a somehow more limited feature of simply specifying whether the links are expected to be unique per DID or not. This, as long as we set
falsefor our deployed pallets would not require any storage migration, and does not require any changes in the benchmarks, so I found it a good compromise.