chore: instantiatable linking pallet #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
force-pushed
the
aa/instantiatable-linking-pallet
branch
2 times, most recently
from
abf6587 to
0514617
Compare
Ad96el
previously approved these changes
Nov 5, 2024
| where | ||
| T::AccountId: Into<LinkableAccountId> + From<sp_runtime::AccountId32> + Into<sp_runtime::AccountId32>, | ||
| <T as frame_system::Config>::AccountId: |
There was a problem hiding this comment.
I think it slipped in. Not a big deal tho.
ntn-x2
force-pushed
the
aa/instantiatable-linking-pallet
branch
from
0514617 to
84d3faf
Compare
ntn-x2
added a commit
that referenced
this pull request
Nov 6, 2024
Part of KILTprotocol/ticket#3650. Built on top of #781. ## Trade-off I chose to go this way instead of providing an optional counter, because providing a counter would require one of the following two approaches: 1. Transform the storage double map into a counted one, requiring a migration also for our currently-deployed pallet, which I wanted to avoid 2. Not use a counter, but iterate every time to make sure there are still "spots" left for the current DID. This would require changing the benchmarking logic as now we have a potentially unbounded iteration happening. I also wanted to avoid that. Hence, the solution was to provide a somehow more limited feature of simply specifying whether the links are expected to be unique per DID or not. This, as long as we set `false` for our deployed pallets would not require any storage migration, and does not require any changes in the benchmarks, so I found it a good compromise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/KILTprotocol/ticket/issues/3650. Built on top of #779.