minor edits to new bindings #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to Kassiopeia 3.2
…module of something else
…al and checking mixing in Locust MC.
…ia from Locust. The conditions are presently global and are defined in small functions that can be dropped into the appropriate static event modifier class. Modified classes are LMCKassSignalGenerator and KSRoot.
…tronRadiationExtractor::ExecutePostStepModification().
…tart of each Kass event.
…n thread status out of ReceivedEventStartCondition.
… KSTrajInterpolatorHermite.cxx pending more testing.
update to Kassiopeia 3.3.2
Feature/eventmod
Revert "Feature/eventmod"
Update to Kassiopeia 3.5
update to Kassiopeia 3.6.1
Check for Boost library as variable or imported target
Kassiopeia v3.7
Kassiopeia v3.7.2
Merge Kassiopeia v3.7.4
Updates with examples
Build fixes on Docker
Update to v3.7.7
Kassiopeia v3.8.0
…ptop after upgrading Root version to > 6.16
…kasper_use_vtk=false.
… With vtk v9.1 the build works.
feature/v3.8.0
Kassiopeia v3.8.2
synchronize main branch
Update main branch
|
Thanks for your PR and for spotting that I just have one small comment about the change in |
richeldichel
requested changes
Nov 21, 2024
Kassiopeia/Bindings/Interactions/Source/KSIntCalculatorMottBuilder.cxx
Outdated
Show resolved
Hide resolved
…lder.cxx Thanks and yes, this makes sense to keep the naming of the interactions themselves consistent, whereas the attributes have a separate syntax. Co-authored-by: Richard S <83545331+richeldichel@users.noreply.github.com>
richeldichel
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some minor edits that we found to be helpful to add to our local container build, using v4.1.0. Depending on suggestions/feedback, we can reconfigure as needed. Thanks in advance.