Update to v3.7.7 #19
Merged
Update to v3.7.7 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Build fixes (update FindFFTW) * Add `CurrentTurns` field to KGElectromagnet * Fix segfault in KGComplexAnnulus
* wdconinc-bugfix-vector-clear-not-empty: std::vector empty() just checks for emtpy; clear() acts on vector
* wdconinc-bugfix-fieldmap-without-gradient: [bugfix] avoid hard crash when gradient not present in maps
* Code cleanup (clang-format + clang-tidy) * Faster XML parsing (now using TinyExpr for math expressions) * New `doc` target to build global code documentation (Doxygen) * Added KEMField unit tests * Added KEMField OpenCL 2.2 headers * CMake will now clean bin+lib install directories before updating files * Bugfixes and usability improvements
…try_painter in root_track_painter
Enhancement: [cmake] default to CMAKE_CXX_STANDARD=14 but allow override
…rary-plane Feature: ROOT track painter arbitrary plane defined by point and normal
…dient Bugfix: Gradient plotting requires dividing by |B|, not multiplying
) * Public directory and file getters for KStaticElectromagnetField * Use directory in SetDumpMagfield3ToFile * Throw warning if fMagfield3File cannot be opened, but continue * KGStaticElectromagnetField::fDirectoryMagfield3(SCRATCH_DEFAULT_DIR) * electromagnet_field attribute directory_magfield3 * fMagfield3File: check for nullptr
…ptions (#46) * [KMagneticField] Check/CheckCore to check if field exists * magnetic_fieldmap boolean magnetic_gradient_numerical attribute * Move warning into KMagneticSuperpositionField::CheckCore * Use VTK GetBounds instead of FindPoint for Check * Instead of booleans, use enum RequirementType { rtNone, rtAll, rtAny, rtOne }
The `KMagneticField::Check()` method needs to be non-virtual to allow different implementation in `KMagnetostaticFieldmap`. For details see issue #46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.