Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change defaults for check_extras and check_weakdeps #202

Merged

Conversation

lgoettgens
Copy link
Collaborator

This should only be merged once a breaking release is staged.

As this builds upon #200, that one has to be merged first.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #202 (b2cc9ad) into master (69a7655) will decrease coverage by 0.19%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   89.63%   89.45%   -0.19%     
==========================================
  Files          10       10              
  Lines         415      512      +97     
==========================================
+ Hits          372      458      +86     
- Misses         43       54      +11     
Flag Coverage Δ
unittests 89.45% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/deps_compat.jl 71.05% <100.00%> (-7.52%) ⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens lgoettgens added this to the 0.8 milestone Oct 16, 2023
@lgoettgens lgoettgens force-pushed the lg/compat-extra-weakdeps-defaults branch 2 times, most recently from 14e4036 to b2cc9ad Compare October 24, 2023 14:02
@lgoettgens lgoettgens merged commit be7ea3a into JuliaTesting:master Oct 24, 2023
18 of 19 checks passed
@lgoettgens lgoettgens deleted the lg/compat-extra-weakdeps-defaults branch October 24, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant