Add option to test_deps_compat to test extras and weakdeps
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 76.80% 76.81% +0.01%
==========================================
Files 11 11
Lines 763 772 +9
==========================================
+ Hits 586 593 +7
- Misses 177 179 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lgoettgens
force-pushed
the
lg/compat-extras-weakdeps
branch
from
bc4d5cd
to
cd0f938
Compare
|
This is a good idea! |
gdalle
reviewed
Oct 12, 2023
|
I'll now merge this although @fingolfin's approval is still missing (he said he currently doesn't have time to review it) to get forward with the 0.8 release. |
lgoettgens
force-pushed
the
lg/compat-extras-weakdeps
branch
from
3e4ceb2
to
64e67f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #178 and adds the same for
weakdepsas well.The tests are disabled by default, until maybe the next breaking release (see #202).