Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the tests from base #70

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Add the tests from base #70

merged 2 commits into from
Jan 17, 2022

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Jan 17, 2022

Move various sparse tests from julia base tests into basetests.jl here.

This leaves mentions of SparseArrays in hashing.jl, ambiguous.jl (sparse tests are excluded there), and precompile.jl. I believe these need to stay in base.

➜  test git:(vs/sparsetests) ✗ git grep SparseArrays | cat
ambiguous.jl:using LinearAlgebra, SparseArrays, SuiteSparse
ambiguous.jl:    STDLIBS = filter!(x -> x != "LinearAlgebra" && x != "SparseArrays" && # Some packages run this test themselves
hashing.jl:using Random, LinearAlgebra, SparseArrays
precompile.jl:                 :SparseArrays, :Statistics, :SuiteSparse, :TOML, :Tar, :Test, :UUIDs, :Unicode,

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #70 (a0edc75) into main (f76aff9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   88.97%   88.98%   +0.01%     
==========================================
  Files           7        7              
  Lines        5667     5667              
==========================================
+ Hits         5042     5043       +1     
+ Misses        625      624       -1     
Impacted Files Coverage Δ
src/sparsematrix.jl 94.95% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76aff9...a0edc75. Read the comment docs.

@ViralBShah
Copy link
Member Author

We should bump stdlibs for this package once we merge, since these tests will be removed from julia base.

@ViralBShah ViralBShah merged commit 16dd9bd into main Jan 17, 2022
@ViralBShah ViralBShah deleted the vs/basetests branch January 17, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants