Move sparse matrix tests to the new SparseArrays.jl repo #43832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViralBShah
added
sparse
KristofferC
approved these changes
Jan 17, 2022
|
@KristofferC What do you think we can do about the use of sparse in hashing.jl? I think it is best to leave it as is since it is testing interaction with the other containers. Also, do we really need using |
If the plan is to move out SparseArrays completely at some point, then the tests have to fully move out as well.
I'm not sure, it doesn't seem to do anything, no. |
N5N3
pushed a commit
to N5N3/julia
that referenced
this pull request
Jan 24, 2022
…3832) * Move sparse matrix tests to the new SparseArrays.jl repo
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…3832) * Move sparse matrix tests to the new SparseArrays.jl repo
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…3832) * Move sparse matrix tests to the new SparseArrays.jl repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests being moved to SparseArrays.jl through JuliaSparse/SparseArrays.jl#70