Add support for the tagStandard41h12 family
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like we have to drop support for Julia v1.3 due to other packages, but the tests are passing on v1.7 and pr looks good to me. |
|
To pass nightly, according to https://github.com/JuliaRobotics/AprilTags.jl/actions/runs/9205485899/job/25323991770?pr=89#step:6:258 we might want to fix Line 249 in 3392cba It looks like something that is already resolved by ColorTypes, and FixedPointNumbers...?
|
|
I'll merge as is, I'm not too worried about nightly, but will maybe add a test on v1.11-alpha. We can fix if its a problem in a more stable release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
tagStandard41h12family.I encountered two difficulties in attempting to add
tagStandard52h13as well astagCircle49h12:tagStandard52h13causes a segfault when runningapriltag_detector_add_family(td, tf).tagCircle49h12) are problematic because they require a mask of white pixels around the circle, but the pixels outside the circle are black.