Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax glib constraints for [BlueZ] #3117

Closed
wants to merge 1 commit into from

Conversation

bramtayl
Copy link
Contributor

configure only seems to be checking if glib is greater than or equal to 2.28

@bramtayl bramtayl changed the title Relax glib constraints Relax glib constraints for [BlueZ] May 30, 2021
@giordano
Copy link
Member

Besides the fact this doesn't work, it doesn't do what you think

@bramtayl
Copy link
Contributor Author

bramtayl commented May 30, 2021

Ok, so here's what I was thinking. The docs say:

The optional keyword argument compat can be used to specify a string for use in the Project.toml of the generated Julia package.

and if 2.28 appeared in the [compat] section of a Project.toml it would make the package work with any versions within [2.28.0, 3.0.0)

@giordano
Copy link
Member

You're assuming that this change would have effect in the registry, but it won't.

@giordano giordano closed this May 30, 2021
@giordano
Copy link
Member

Also, the fact that tests in #3033 are running (and passing) shows that this change wasn't even needed

@bramtayl
Copy link
Contributor Author

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants