-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding BlueZ to [PulseAudio] #3033
Conversation
I'll try rerunning later to give BlueZ a chance to get situated |
@giordano looks like BlueZ installed successfully but the bluetooth.h header file is missing. I can't find it in the wizard destdir either. They mention it in the build log for BlueZ, though:
So, do you happen to know where it went? |
@giordano help? Why did you add the glib compat requirement to BlueZ to be 2.68.1? Looks like something else is requiring it to be 2.59? |
Gettext isn't a runtime dependency |
P/PulseAudio/build_tarballs.jl
Outdated
# TOOD: verify Gettext is actually needed at runtime | ||
Dependency(PackageSpec(name="Gettext_jll", uuid="78b55507-aeef-58d4-861c-77aaff3498b1"), v"0.20.1"; compat="=0.20.1") | ||
Dependency(PackageSpec(name="Glib_jll", uuid="7746bdde-850d-59dc-9ae8-88ece973131d"), v"2.59.0"; compat="2.59.0") | ||
Dependency(PackageSpec(name="Glib_jll", uuid="7746bdde-850d-59dc-9ae8-88ece973131d")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glib_jll
must have a compat bound: #3024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, removed that accidentally in the merge
Is |
Is |
Is |
Is |
|
I really don't understand how pulseaudio works, none of the libraries nor executables link to any of these libraries 🤷 |
I mean, I can remove them if you think I should. I was working from the configure output.
Where do I find this kind of info? |
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
for file in bin/* lib/*.so; do
echo "${file}"
readelf -d "${file}" | grep "NEEDED"
done |
Hmm, well, at the end of the wizard, there's a section:
And I didn't select everything. A full list would have been
Could that have something to do with it? |
"That" what? The files are still there, regardless of whether they're listed as products or not |
Oh, I was thinking that maybe the reason it didn't look like some dependencies were used was that they were only used by unexported products. Anyway, I guess the answer is no and this made the tests fail and I'm confused again. |
Also,
maybe this could be included as a check at the end of the wizard it it's reliable. |
Those lines don't check much. And libraries listed as products are already dlopened. |
Eh, I decided I'd just get rid of them |
Hmm, dunno what's going on with 32 bit linux but otherwise good? |
@giordano should I just disable 32-bit linux? |
I think it'd be better to understand what is the problem |
Yes that makes sense. I just tried putting all the dependencies back and 32 bit linux still failed, which means something external must have changed between the last time tests all passed a month ago and now. The error
makes me think that there might be something wrong with the new version of |
Yay! Good? |
I'm not really comfortable with adding extra dependency without changing the version number |
Should I bump the version to 14.99.2 then? The version number makes me think it might be a beta? Or maybe just wait for 15? |
@staticfloat I guess Mose is on vacation? Anyway, it's a new version now |
Yep, looks good to me! |
* Try adding BlueZ * Rerun CI * Rerun CI * try again * Remove gettext * Add back in Glib compat bounds * Update P/PulseAudio/build_tarballs.jl Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> * Add all products * Add version numbers to products * interpolate version * Remove apparently unused dependencies * Tests fail without SBC? * Tests fail without check * Does it still work with all dependencies? * Retrim dependencies * 15.0 * Create rpath.patch * Create fastmath.patch * Create capabilities.patch * apply patches * -R * reverse patches * reorder * bundled * source * remove products Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
No description provided.