FIX don't shell out when you can mv

[hayd]

fixes #7041

[simonster]

AFAIK rmdir can only delete empty directories, so it's not a drop-in replacement for rm -rf. I'm not sure if we already have a function to delete files and folders recursively, but if not, it shouldn't be too hard to write.

[hayd]

Moved this aspect to a separate PR.

One potential solution is to add recursive argument (with the first few lines):

function rmdir(path::String, recursive::Bool=false)
    if recursive
        dir_contents = map(p -> joinpath(path, p), readdir(path))
        for f=dir_contents
            isfile(f) && rm(f) || rmdir(f, true)
        end
    end
    @unix_only ret = ccall(:rmdir, Int32, (Ptr{Uint8},), bytestring(path))
    @windows_only ret = ccall(:_rmdir, Int32, (Ptr{Uint8},), bytestring(path))
    systemerror(:rmdir, ret != 0)
end

Should I pull out the rm -rf bits and add this to a separate PR?

[StefanKarpinski]

If this will also handle files then calling it rmrf might be better.

[StefanKarpinski]

Although I guess allowing recursive to also remove files would be reasonable too.

[hayd]

@simonster @StefanKarpinski I've fixed this up to be just the two calls to mv.

[simonster]

I think that mv() requires that the second argument be the new path as opposed to the destination directory.

[hayd]

@simonster you're right, sorry about that. corrected