Merge pull request #7046 from hayd/dont_shell_out

FIX don't shell out when you can mv
JuliaLang · Jun 9, 2014 · b771481 · b771481
2 parents 247e7f8 + 4f1de15
commit b771481
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/base/pkg/write.jl b/base/pkg/write.jl
@@ -23,7 +23,7 @@ end
 function install(pkg::String, sha1::String)
     prefetch(pkg, sha1)
     if isdir(".trash/$pkg")
-        run(`mv .trash/$pkg ./`)
+        mv(".trash/$pkg", "./$pkg")
     else
         Git.run(`clone -q $(Cache.path(pkg)) $pkg`)
     end
@@ -40,7 +40,7 @@ end
 function remove(pkg::String)
     isdir(".trash") || mkdir(".trash")
     ispath(".trash/$pkg") && run(`rm -rf .trash/$pkg`)
-    run(`mv $pkg .trash/`)
+    mv(pkg, ".trash/$pkg")
 end
 
 end # module