-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take into account color and unicode in matrix alignment #45751
Conversation
Helps with debugging. Needs JuliaLang/julia#45751 for proper formatting, but works without it.
Helps with debugging. Needs JuliaLang/julia#45751 for proper formatting, but works without it.
Without this, alignment would count characters rather than textwidth as well as counting inline escape sequences in colored output. Fix that by using uncolored printing for alignment and textwidth rather than number of codepoints.
Test failure is because the branch is missing #45670. |
Can this get backported? |
Without this, alignment would count characters rather than textwidth as well as counting inline escape sequences in colored output. Fix that by using uncolored printing for alignment and textwidth rather than number of codepoints. (cherry picked from commit 626acd4)
Without this, alignment would count characters rather than textwidth as well as counting inline escape sequences in colored output. Fix that by using uncolored printing for alignment and textwidth rather than number of codepoints. (cherry picked from commit 626acd4)
Can this be done for julia/stdlib/LinearAlgebra/src/diagonal.jl Lines 136 to 138 in 7212c03
Lines 42 to 45 in 8af6731
and get a string from |
Without this, alignment would count characters rather than
textwidth as well as counting inline escape sequences in
colored output. Fix that by using uncolored printing for
alignment and textwidth rather than number of codepoints.