-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip concrete-foldability test on x86 machines #45670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But just print bad effects instead – especially `[sin|cos|tan](::Float32)` seem to be analyzed as non-foldable sometimes non-deterministically, somehow. We need to dig into what's leading to the bad analysis with Cthulhu on each platform, but this homework is left for the readers with access.
This is ok for the moment, but having something like this is really a sign that something is fundamentally broken somewhere, so we should track that down as soon as possible. |
Merging now while you look into that, so that we have more green CI and aren't blocking other people's work |
Failure is test order dependent and reproducible with
|
This was referenced Jun 22, 2022
KristofferC
pushed a commit
that referenced
this pull request
Jul 20, 2022
But just print bad effects instead – especially `[sin|cos|tan](::Float32)` seem to be analyzed as non-foldable sometimes non-deterministically, somehow. We need to dig into what's leading to the bad analysis with Cthulhu on each platform, but this homework is left for the readers with access. Tests added in #45613 (cherry picked from commit ef42205)
32 tasks
aviatesk
added a commit
that referenced
this pull request
Jul 26, 2022
But just print bad effects instead – especially `[sin|cos|tan](::Float32)` seem to be analyzed as non-foldable sometimes non-deterministically, somehow. We need to dig into what's leading to the bad analysis with Cthulhu on each platform, but this homework is left for the readers with access. Tests added in #45613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And just print bad effects on x86 machines – especially
[sin|cos|tan](::Float32)
seem to be analyzed as non-foldable, but non deterministically somehow.
We need to dig into what's leading to the bad analysis with Cthulhu.