Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip concrete-foldability test on x86 machines #45670

Merged
merged 1 commit into from
Jun 15, 2022
Merged

skip concrete-foldability test on x86 machines #45670

merged 1 commit into from
Jun 15, 2022

Conversation

aviatesk
Copy link
Member

And just print bad effects on x86 machines – especially [sin|cos|tan](::Float32)
seem to be analyzed as non-foldable, but non deterministically somehow.
We need to dig into what's leading to the bad analysis with Cthulhu.

But just print bad effects instead – especially `[sin|cos|tan](::Float32)`
seem to be analyzed as non-foldable sometimes non-deterministically, somehow.
We need to dig into what's leading to the bad analysis with Cthulhu on
each platform, but this homework is left for the readers with access.
@Keno
Copy link
Member

Keno commented Jun 14, 2022

This is ok for the moment, but having something like this is really a sign that something is fundamentally broken somewhere, so we should track that down as soon as possible.

@vtjnash vtjnash merged commit ef42205 into master Jun 15, 2022
@vtjnash vtjnash deleted the avi/45613 branch June 15, 2022 18:37
@vtjnash
Copy link
Member

vtjnash commented Jun 15, 2022

Merging now while you look into that, so that we have more green CI and aren't blocking other people's work

@Keno
Copy link
Member

Keno commented Jun 22, 2022

Failure is test order dependent and reproducible with

JULIA_CPU_THREADS=1 ../julia runtests.jl LinearAlgebra/svd LinearAlgebra/pinv LinearAlgebra/givens LinearAlgebra/structuredbroadcast numbers copy math
Running parallel tests with:
  nworkers() = 1
  nthreads() = 1
  Sys.CPU_THREADS = 1
  Sys.total_memory() = 1007.822 GiB
  Sys.free_memory() = 992.748 GiB

Test                          (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
LinearAlgebra/svd                  (1) |        started at 2022-06-22T03:20:39.381
LinearAlgebra/svd                  (1) |    50.03 |   2.66 |  5.3 |    7520.24 |   665.83
LinearAlgebra/pinv                 (1) |        started at 2022-06-22T03:21:29.526
LinearAlgebra/pinv                 (1) |     9.04 |   0.66 |  7.3 |    1456.71 |   839.06
LinearAlgebra/givens               (1) |        started at 2022-06-22T03:21:38.564
LinearAlgebra/givens               (1) |     4.25 |   0.21 |  5.0 |     441.16 |   848.18
LinearAlgebra/structuredbroadcast  (1) |        started at 2022-06-22T03:21:42.814
LinearAlgebra/structuredbroadcast  (1) |    33.33 |   2.27 |  6.8 |    4345.93 |   909.84
numbers                            (1) |        started at 2022-06-22T03:22:16.142
numbers                            (1) |    48.12 |   1.14 |  2.4 |    4384.62 |  1356.91
copy                               (1) |        started at 2022-06-22T03:23:04.259
copy                               (1) |     2.52 |   0.09 |  3.4 |     277.91 |  1356.91
math                               (1) |        started at 2022-06-22T03:23:06.782
┌ Warning: bad effects found for sin(::Float32)
│   eff = (+c,+e,?n,?t,+s)
└ @ Main.Test6Main_math ~/julia/test/math.jl:1467
┌ Warning: bad effects found for cos(::Float32)
│   eff = (+c,+e,?n,?t,+s)
└ @ Main.Test6Main_math ~/julia/test/math.jl:1467
┌ Warning: bad effects found for tan(::Float32)
│   eff = (+c,+e,?n,?t,+s)
└ @ Main.Test6Main_math ~/julia/test/math.jl:1467
math                               (1) |    36.14 |   1.31 |  3.6 |    4391.28 |  1625.89

Test Summary: |    Pass  Broken    Total     Time
  Overall     | 3493226       3  3493229  3m04.5s
    SUCCESS

@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Jul 20, 2022
KristofferC pushed a commit that referenced this pull request Jul 20, 2022
But just print bad effects instead – especially `[sin|cos|tan](::Float32)`
seem to be analyzed as non-foldable sometimes non-deterministically, somehow.
We need to dig into what's leading to the bad analysis with Cthulhu on
each platform, but this homework is left for the readers with access.

Tests added in #45613

(cherry picked from commit ef42205)
@aviatesk aviatesk mentioned this pull request Jul 20, 2022
32 tasks
aviatesk added a commit that referenced this pull request Jul 26, 2022
But just print bad effects instead – especially `[sin|cos|tan](::Float32)`
seem to be analyzed as non-foldable sometimes non-deterministically, somehow.
We need to dig into what's leading to the bad analysis with Cthulhu on
each platform, but this homework is left for the readers with access.

Tests added in #45613
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants