optimizer: enhance SROA, enable PhiNode load forwarding with uninitialized fields
#43208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added
the
compiler:optimizer
|
@nanosoldier |
aviatesk
changed the title
PhiNodefy load forwarding with uninitialized fieldsPhiNode load forwarding with uninitialized fields
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
force-pushed
the
avi/sroa
branch
2 times, most recently
from
21fbd77
to
926ac20
Compare
…itialized allocations This commit addresses this [TODO comment](https://github.com/JuliaLang/julia/blob/3a5146f6b94e32bef5a812619068f82218b5482c/base/compiler/ssair/passes.jl#L831-L832). Now SROA can eliminate this sort of allocation: ```julia let src = code_typed((Bool,)) do cond r = Ref{Any}() if cond r[] = 42 else r[] = 32 end return r[] end |> only |> first @test !any(isnew, src.code) end ```
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…aLang#43208) This commit addresses this [TODO comment](https://github.com/JuliaLang/julia/blob/3a5146f6b94e32bef5a812619068f82218b5482c/base/compiler/ssair/passes.jl#L831-L832), and allows SROA pass to form `PhiNode`s for uninitialized fields when we can prove there are safe `setfield!` calls in all dominated control flows. Now SROA can eliminate this sort of allocation: ```julia let src = code_typed((Bool,)) do cond r = Ref{Any}() if cond r[] = 42 else r[] = 32 end return r[] end |> only |> first @test !any(isnew, src.code) end ```
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…aLang#43208) This commit addresses this [TODO comment](https://github.com/JuliaLang/julia/blob/3a5146f6b94e32bef5a812619068f82218b5482c/base/compiler/ssair/passes.jl#L831-L832), and allows SROA pass to form `PhiNode`s for uninitialized fields when we can prove there are safe `setfield!` calls in all dominated control flows. Now SROA can eliminate this sort of allocation: ```julia let src = code_typed((Bool,)) do cond r = Ref{Any}() if cond r[] = 42 else r[] = 32 end return r[] end |> only |> first @test !any(isnew, src.code) end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses this TODO comment.
Now SROA can eliminate this sort of allocation: